Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RadioFormField: changed optionDisplay to optionLabel in RadioFormField #8533

Merged
merged 3 commits into from
Sep 18, 2024
Merged

RadioFormField: changed optionDisplay to optionLabel in RadioFormField #8533

merged 3 commits into from
Sep 18, 2024

Conversation

xakep8
Copy link
Contributor

@xakep8 xakep8 commented Sep 13, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@xakep8 xakep8 requested a review from a team as a code owner September 13, 2024 11:14
@netlify Netlify
Copy link

netlify bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 2797cbd
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66e8342650146b00081a11e9
😎 Deploy Preview https://deploy-preview-8533--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@rithviknishad can you approve the netlify deploy

rithviknishad
rithviknishad requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you discard the changes made to the package-lock.json file?

@xakep8
Copy link
Contributor Author

xakep8 commented Sep 13, 2024

@rithviknishad I've reverted the changes made to package-lock.json.

@nihal467
Copy link
Member

LGTM @rithviknishad tested it via locally

@khavinshankar khavinshankar merged commit 775a8e5 into ohcnetwork:develop Sep 18, 2024
19 checks passed
@github-actions GitHub Actions
Copy link

@xakep8 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@xakep8 xakep8 deleted the optionLabel_change branch September 18, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@shivankacker shivankacker shivankacker approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistency in label prop name for RadioFormField
5 participants
@xakep8 @nihal467 @shivankacker @rithviknishad @khavinshankar