Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Care Plugin Support #8660

Merged
merged 48 commits into from
Oct 16, 2024
Merged

WIP: Care Plugin Support #8660

merged 48 commits into from
Oct 16, 2024

Conversation

gigincg
Copy link
Member

@gigincg gigincg commented Sep 29, 2024 •
edited by nihal467
Loading

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Beside npm i we need to use npm run install-all before npm run dev command : Update it in the readme

@gigincg gigincg requested a review from a team as a code owner September 29, 2024 10:31
@netlify Netlify
Copy link

netlify bot commented Sep 29, 2024 •
edited
Loading

❌ Deploy Preview for care-ohc failed.

Name Link
🔨 Latest commit 05bc74c
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670f95994f9f5200082a6610

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Sep 29, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 29, 2024 •
edited
Loading

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 05bc74c
Status:⚡️  Build in progress...

View logs

@gigincg gigincg added needs testing and removed Deploy-Failed Deplyment is not showing preview labels Oct 1, 2024
@cypress Cypress
Copy link

cypress bot commented Oct 1, 2024 •
edited
Loading

CARE    Run #3681

Run Properties:  status check passed Passed #3681  •  git commit e37f9af8e9: WIP: Care Plugin Support
Project CARE
Run status status check passed Passed #3681
Run duration 03m 29s
Commit git commit e37f9af8e9: WIP: Care Plugin Support
Committer Gigin George
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@nihal467
Copy link
Member

nihal467 commented Oct 1, 2024

LGTM

bodhish
bodhish reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Everything in src/Routers/routes/ can be merged early as another PR to reduce clutter in this PR.
  • Can you push an app repo, I am unable to review the config bit as I don't know the shape of manifest.

cc: @shivankacker

.nvmrc Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
src/Common/hooks/useConfig.ts Outdated Show resolved Hide resolved
src/PluginEngine.tsx Outdated
Comment on lines 11 to 13
type SupportedPluginExtensions =
| "DoctorConnectButtons"
| "PatientExternalRegistration";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, can't we do something like route and id?
This is quite restricting, we need to whitelist all locations. 🤔 (Just a thought)

src/Routers/AppRouter.tsx Show resolved Hide resolved
src/Routers/AppRouter.tsx Outdated Show resolved Hide resolved
src/pluginMap.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

👋 Hi, @gigincg,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview and removed merge conflict pull requests with merge conflict labels Oct 3, 2024
@bodhish
Copy link
Member

bodhish commented Oct 7, 2024

@gigincg can you update the status here?

rithviknishad
rithviknishad requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update README to instruct how to install plugins (npm run setup and first time setup npm run install-all)

@nihal467 nihal467 removed their assignment Oct 14, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 15, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @gigincg,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview and removed merge conflict pull requests with merge conflict labels Oct 15, 2024
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Oct 15, 2024
@shivankacker shivankacker removed their assignment Oct 16, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 16, 2024
View reviewed changes
scripts/setup-care-apps.js Fixed Show fixed Hide fixed
scripts/setup-care-apps.js Fixed Show fixed Hide fixed
scripts/setup-care-apps.js Fixed Show fixed Hide fixed
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @gigincg,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 16, 2024
@gigincg gigincg merged commit 45a3930 into develop Oct 16, 2024
4 of 19 checks passed
@gigincg gigincg deleted the plugs branch October 16, 2024 10:30
@github-actions GitHub Actions
Copy link

@gigincg Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Oct 16, 2024
@khavinshankar khavinshankar mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivankacker shivankacker shivankacker approved these changes

@rithviknishad rithviknishad rithviknishad requested changes

@bodhish bodhish bodhish requested changes

Assignees
No one assigned
Labels
changes required Deploy-Failed Deplyment is not showing preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use absolute paths for imports & Introduce Frontend Plugins
7 participants
@gigincg @nihal467 @bodhish @tellmeY18 @shivankacker @rithviknishad @khavinshankar