Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Patient Search and Register UI #9400

Draft
wants to merge 9 commits into
base: form-field-v1
Choose a base branch
from

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Dec 12, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link
Contributor

coderabbitai bot commented Dec 12, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shivankacker shivankacker changed the title search page New Patient Search and Register UI Dec 12, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 673cc2f
Status: ✅  Deploy successful!
Preview URL: https://4da93399.care-fe.pages.dev
Branch Preview URL: https://patient-registration.care-fe.pages.dev

View logs

@shivankacker shivankacker self-assigned this Dec 12, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 13, 2024
Copy link

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Dec 14, 2024
@nihal467
Copy link
Member

nihal467 commented Dec 15, 2024

Bug Report

Major Functionality


image
image

  • When we create a patient with a 20-digit number, the system successfully redirects to the consultation page. However, when I check the respective patient details page, it reflects as 'undefined'.
  • A similar issue arises when we fill only the date in the DOB field and leave the month and year blank. Ensure that all the fields have proper validation.

image

  • No New Patient Registration is possible either with DOB or Age, in all scenario, the formatting issue is thrown and the registration fails

image

  • The entire insurance details section is missing from the patient registration form.

image

  • When a patient is registered with age instead of DOB, only display the age in the 'Search Patient' UI.
  • Rename the column name from DOB to Age/DOB

Minor Functionality


image

  • The Shift+P shortcut is not working on the Windows OS.
  • The representation of the key on the button doesn't look good at all. stick to the figma

image

  • Reset the search input field when the corresponding badge is manually closed.

image

  • The placeholder of the IP/OP number is clipping in.

image

  • Add a skeleton loader to the 'Search Patient' page while the data is being fetched based on the input.

image

  • Keep the DOB format as DD-MM-YYYY on the 'Search Patient' page.

image

  • Remove the "*" for Landmark and Ward as they are non-mandatory fields.
  • Add placeholders for all dropdowns as shown in our latest Figma design.

image

  • Rename 'Non-binary' to 'Transgender' in the sex field.

image

  • Keep the phone number hardcoded to have +91 in the field.
  • The phone number should only accept 10 digits.

image

  • Emergency contact person is missing field validation

image

  • The autofill is not working for the district because the field enabling is facing some delay.

image

  • The tab switching functionality does not properly use colors, making it difficult for users to identify the currently active tab on the initial load of the 'All Patients' page.

image

  • add spacing between the badges and the search field in the patient list page

Question needs clarification


image

  • Why are we mixing the IP/OP column with the name? Isn't it better to keep them separate?

image

  • Disabling ABDM and HCX on this deploy was intentional? We need to enable them for testing purposes.

image

  • The entire volunteer section and related items are missing from the registration form. Is this intentional?

  • The entire patient transfer workflow from the patient registration form seems to be missing. How do we plan to handle this?

@shivankacker
Copy link
Member Author

@nihal467 we are not including insurance and volunteer details right now.

  • Fixed the field validations
  • A lot of UI bugs in the minor issues you pointed out happened when i pulled form field branch. I let them be for now because I didn't want to break any functionality
  • Pushing the other minor changes in a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants