Avoid negative number in Add Triage option in Facilities Page #9430
Conversation
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Suggested Labels
Suggested Reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/components/Facility/FacilityHomeTriage.tsx (1)
24-28: Consider adding type assertions for better type safetyTo improve type safety and make the code more maintainable, consider adding explicit type assertions or runtime checks.
- String(Math.max(0, result.num_patients_visited || 0)), + String(Math.max(0, Number(result.num_patients_visited) || 0)), - String(Math.max(0, result.num_patients_home_quarantine || 0)), + String(Math.max(0, Number(result.num_patients_home_quarantine) || 0)), - String(Math.max(0, result.num_patients_isolation || 0)), + String(Math.max(0, Number(result.num_patients_isolation) || 0)), - String(Math.max(0, result.num_patient_referred || 0)), + String(Math.max(0, Number(result.num_patient_referred) || 0)), - String(Math.max(0, result.num_patient_confirmed_positive || 0)), + String(Math.max(0, Number(result.num_patient_confirmed_positive) || 0)),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/Facility/FacilityHomeTriage.tsx(1 hunks)
🔇 Additional comments (1)
src/components/Facility/FacilityHomeTriage.tsx (1)
24-28: LGTM! Verify data type handling
The implementation correctly prevents negative values and handles undefined/null cases. The consistent approach across all numeric fields improves maintainability.
Let's verify the TypeScript types for these fields:
✅ Verification successful
Type safety is properly implemented
The code changes align perfectly with the PatientStatsModel interface in src/components/Facility/models.tsx, where all the relevant fields are correctly typed as optional numbers (num_patients_visited?: number, etc.). The Math.max(0, value || 0) implementation safely handles both the TypeScript types and runtime edge cases.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the type definitions for triage data
# Look for interface/type definitions related to triage data
ast-grep --pattern 'interface $INTERFACE {
$$$
num_patients_visited?: $TYPE;
$$$
}'
ast-grep --pattern 'type $TYPE = {
$$$
num_patients_visited?: $TYPE;
$$$
}'
Length of output: 849
Proposed Changes
Code Reviewera : @Jacobjeevan @rithviknishad @bodhish
Summary by CodeRabbit