Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the makefile template in build-system doesn't trigger a makefile regeneration #572

Open
ohmtech-rdi opened this issue Jun 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ohmtech-rdi
Copy link
Owner

ohmtech-rdi commented Jun 18, 2023

Changing the makefile template in build-system doesn't trigger a makefile regeneration.

This is annoying because if we introduce new symbols in the simulator module, we can't trigger a build error if the symbol is missing because VCV Rack needs -undefined dynamic_lookup on macOS, and this will silently fail in Rack when loading the module, which makes it hard for the user to understand why it doesn't work anymore.

Must be because the action rule doesn't depend itself on the action source code?

@ohmtech-rdi ohmtech-rdi added the bug Something isn't working label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant