You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
openvpn-status-parser uses the "Common Name" as the dict key in the connected_clients attributes.
This leads to a problem when no client certificate is used to authenticate users, but only login/pass, as the "Common Name" field is "UNDEF" for all connected users.
A consequence of this is that when iterating through all connected clients, the same key is used, and its value is overwritten each time, resulting in a list containing only one client.
Another consequence (not yet tested but supposed), is that even if client certificates are used, if the same user has multiple active sessions on the same VPN server (because he has several terminals, or connection issue), only one active connection will be seen.
A fix for this would be to use "Client ID" (which is supposed to be unique) instead of "Common Name" as the key to the connected_clients attribute.
I'll send a PR implementing this fix.
The text was updated successfully, but these errors were encountered:
openvpn-status-parser uses the "Common Name" as the dict key in the
connected_clients
attributes.This leads to a problem when no client certificate is used to authenticate users, but only login/pass, as the "Common Name" field is "UNDEF" for all connected users.
A consequence of this is that when iterating through all connected clients, the same key is used, and its value is overwritten each time, resulting in a list containing only one client.
Another consequence (not yet tested but supposed), is that even if client certificates are used, if the same user has multiple active sessions on the same VPN server (because he has several terminals, or connection issue), only one active connection will be seen.
A fix for this would be to use "Client ID" (which is supposed to be unique) instead of "Common Name" as the key to the
connected_clients
attribute.I'll send a PR implementing this fix.
The text was updated successfully, but these errors were encountered: