Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe from identity contracts after leaving group #1672

Closed
taoeffect opened this issue Jul 19, 2023 · 0 comments · Fixed by #1885
Closed

Unsubscribe from identity contracts after leaving group #1672

taoeffect opened this issue Jul 19, 2023 · 0 comments · Fixed by #1885
Assignees
Labels
App:Frontend Kind:Bug Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:Contracts Issues involving modifications to contracts

Comments

@taoeffect
Copy link
Member

taoeffect commented Jul 19, 2023

Problem

If we are kicked out of a group, or if we leave a group, we remain subscribed to the identity contracts that were in that group.

This is a waste of resources if we are no longer interacting with these contracts.

Solution

For all of the identity contracts with whom we do not have any open DMs, unsubscribe from them.

Note: the e2e-protocol branch is merging the mailbox.js contract into the identity.js contract. So for this PR do not worry about unsubscribing from the corresponding mailbox contracts. Just unsubscribe from the identity contracts with whom we do not have any other open interactions (e.g. DMs) with.

EDIT: it is best to probably wait until the e2e-protocol branch is merged. See PR #1521.

EDIT2: I think this PR would be best addressed by using reference counting (see #1249), but it can also be addressed by other means (see @Silver-IT's #1885)

@taoeffect taoeffect added Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:Up-for-grabs App:Frontend Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. Note:Contracts Issues involving modifications to contracts Kind:Bug labels Jul 19, 2023
@Silver-IT Silver-IT self-assigned this Sep 14, 2023
@Silver-IT Silver-IT linked a pull request Mar 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App:Frontend Kind:Bug Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:Contracts Issues involving modifications to contracts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants