Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary key-value errors in console when app starts logged out #2452

Closed
taoeffect opened this issue Dec 9, 2024 · 1 comment
Closed

Comments

@taoeffect
Copy link
Member

Problem

Screenshot 2024-12-09 at 10 32 04 AM

'gi.actions/identity/kv/load' and possibly also 'gi.actions/group/kv/load' trigger these errors when starting up a fresh session with no logged in user.

Also, there's a typo in error message in group-kv.js that makes it say 'gi.actions/identity/kv/load' instead of 'gi.actions/group/kv/load':

sbp('okTurtles.events/on', ONLINE, () => {
  sbp('gi.actions/group/kv/load').catch(e => {
    console.error("Error from 'gi.actions/identity/kv/load' after reestablished connection:", e)
  })
})

Solution

Do not log any error to the console if we are not logged in.

Could be as simple as checking whether or not we're logged in inside of the ONLINE handler and not calling load if we're not logged in.

@taoeffect
Copy link
Member Author

Closed by both #2357 and #2454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants