From dde7a45404941f8bd08e98fc148207bcf7c1b182 Mon Sep 17 00:00:00 2001
From: Vayras <89837102+Vayras@users.noreply.github.com>
Date: Wed, 27 Nov 2024 11:50:40 +0530
Subject: [PATCH 1/3] fixed tooltip position on mobile
---
.../dashboard/SentenceWithMemberTooltip.vue | 96 +++++++++----------
1 file changed, 48 insertions(+), 48 deletions(-)
diff --git a/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue b/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue
index 773a757ada..7f9d938a02 100644
--- a/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue
+++ b/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue
@@ -1,48 +1,48 @@
-
-component(
- is='Tooltip'
- :key='members.length'
- :opacity='members.length === 0 ? 0 : 0.95'
- triggerElementSelector='.t-trigger'
- direction='bottom-right'
-)
- // The reason for using tag here instead of and specifying 'key' attr is,
- // to fix the bug where the link between the tooltip content(template(slot='tooltip') below) and the trigger target element(.t-trigger)
- // gets broken when "members" prop is updated. Tooltip gets destoryed and re-mounted in response to the prop change this way.
- slot
-
- template(v-if='members && members.length' slot='tooltip')
- .c-member-name(
- v-for='(name, index) in members'
- :key='`member-${index}`'
- )
- .has-ellipsis {{ name }}
-
-
-
-
-
+
+component(
+ is='Tooltip'
+ :key='members.length'
+ :opacity='members.length === 0 ? 0 : 0.95'
+ triggerElementSelector='.t-trigger'
+ direction='bottom-center'
+)
+ // The reason for using tag here instead of and specifying 'key' attr is,
+ // to fix the bug where the link between the tooltip content(template(slot='tooltip') below) and the trigger target element(.t-trigger)
+ // gets broken when "members" prop is updated. Tooltip gets destoryed and re-mounted in response to the prop change this way.
+ slot
+
+ template(v-if='members && members.length' slot='tooltip')
+ .c-member-name(
+ v-for='(name, index) in members'
+ :key='`member-${index}`'
+ )
+ .has-ellipsis {{ name }}
+
+
+
+
+
From 1be67bc758bd25c874fb48ba6cbd3f01d0750549 Mon Sep 17 00:00:00 2001
From: Vayras <89837102+Vayras@users.noreply.github.com>
Date: Sat, 30 Nov 2024 23:27:53 +0530
Subject: [PATCH 2/3] fix
---
.../views/containers/dashboard/SentenceWithMemberTooltip.vue | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue b/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue
index 7f9d938a02..ba25772650 100644
--- a/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue
+++ b/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue
@@ -4,7 +4,7 @@ component(
:key='members.length'
:opacity='members.length === 0 ? 0 : 0.95'
triggerElementSelector='.t-trigger'
- direction='bottom-center'
+ direction='bottom-middle'
)
// The reason for using tag here instead of and specifying 'key' attr is,
// to fix the bug where the link between the tooltip content(template(slot='tooltip') below) and the trigger target element(.t-trigger)
From 7e27f0951c75b07ba92d684a6e97379f32f1bba1 Mon Sep 17 00:00:00 2001
From: Tushar Vyas <89837102+Vayras@users.noreply.github.com>
Date: Mon, 2 Dec 2024 00:20:36 +0530
Subject: [PATCH 3/3] fixed reference
---
.../views/containers/dashboard/SentenceWithMemberTooltip.vue | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue b/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue
index ba25772650..c74cbb2436 100644
--- a/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue
+++ b/frontend/views/containers/dashboard/SentenceWithMemberTooltip.vue
@@ -4,7 +4,7 @@ component(
:key='members.length'
:opacity='members.length === 0 ? 0 : 0.95'
triggerElementSelector='.t-trigger'
- direction='bottom-middle'
+ direction='bottom'
)
// The reason for using tag here instead of and specifying 'key' attr is,
// to fix the bug where the link between the tooltip content(template(slot='tooltip') below) and the trigger target element(.t-trigger)