Contract deletion #2495
Draft
Contract deletion #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
1927-design-implement-contract-deletion-op_contract_delete
|
| Run status |
|
| Run duration | 10m 30s |
| Commit |
|
| Committer | Ricardo Iván Vieitez Parra |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
112
|
| View all changes introduced in this branch ↗︎ | |
corrideat
force-pushed
the
1927-design-implement-contract-deletion-op_contract_delete
branch
from
ee948fb to
0b72902
Compare
corrideat
force-pushed
the
1927-design-implement-contract-deletion-op_contract_delete
branch
from
6d0de94 to
4055758
Compare
corrideat
commented
Jan 12, 2025
|
|
||
| switch (cheloniaState.type) { | ||
| case 'gi.contracts/chatroom': { | ||
| // TODO: Leave chatroom on our identity contract or our group, if we've |
There was a problem hiding this comment.
Not having a chatroom->parent relationship makes this difficult to implement (efficiently, at least). We also need to add a new action to the identity contract, to delete chatrooms (currently, it's append-only).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1927