New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: change get_plugin_data; add get_plugin_value #11

Merged

faradox merged 1 commit into main from fix/plugin-data-access

Nov 30, 2023

Contributor

faradox commented Nov 30, 2023

This PR introduces 2 changes:

get_plugin_data(plugin_name, key) now behaves as originally defined: It always returns a list of NendoPluginData. Also, the way NendoBlobs are attached to the list upon loading was fixed.
get_plugin_value(key) was added that will return the string value for the plugin_data entry corresponding to the given key. If multiple entries exist, the first one is returned.


          fix: change get_plugin_data; add get_plugin_value

e788e82

faradox requested a review from aaronabebe

November 30, 2023 09:16

aaronabebe approved these changes

View reviewed changes

Contributor

aaronabebe left a comment

cool! i like the solution with having an extra method for it. makes more sense!

faradox merged commit 3277910 into main

5 checks passed

faradox deleted the fix/plugin-data-access branch

November 30, 2023 10:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet