From 8ed3220a424a741ad5c075dffe09126e38d156a4 Mon Sep 17 00:00:00 2001 From: faradox Date: Sat, 25 Nov 2023 13:11:44 +0100 Subject: [PATCH 1/2] fix: filter_tracks access track_type bug --- src/nendo/library/sqlalchemy_library.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nendo/library/sqlalchemy_library.py b/src/nendo/library/sqlalchemy_library.py index ce7f778..b4a14f7 100644 --- a/src/nendo/library/sqlalchemy_library.py +++ b/src/nendo/library/sqlalchemy_library.py @@ -1200,7 +1200,7 @@ def filter_tracks( # apply track type filter if applicable if track_type is not None: if isinstance(track_type, list): - query = query.filter(model.NendoTrackDB.value.in_(track_type)) + query = query.filter(model.NendoTrackDB.track_type.in_(track_type)) else: query = query.filter(model.NendoTrackDB.track_type == track_type) From d82eb0dbf142660ba58d72ae30db6402ff200fa8 Mon Sep 17 00:00:00 2001 From: faradox Date: Sat, 25 Nov 2023 13:14:44 +0100 Subject: [PATCH 2/2] update test for filter_tracks method --- tests/test_library.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test_library.py b/tests/test_library.py index cabb7a1..093be31 100644 --- a/tests/test_library.py +++ b/tests/test_library.py @@ -169,6 +169,8 @@ def test_filter_by_track_type(self): result = nd.library.filter_tracks(track_type="stem") self.assertEqual(len(result), 1) self.assertEqual(result[0].id, test_track_1.id) + result = nd.library.filter_tracks(track_type=["stem", "track"]) + self.assertEqual(len(result), 2) def test_get_tracks_filtered_by_collection(self): """Test filtering of tracks by collection."""