Skip to content

Commit

Permalink
fix: adds branches back to Applitools (#1943)
Browse files Browse the repository at this point in the history
* fix: add branches back to Applitools

* chore: testing branch name logging

* fix: removed explicit baseline

* fix: updated Applitools branch name
  • Loading branch information
KevinGhadyani-Okta authored Aug 25, 2023
1 parent b5a16c1 commit 4c96f48
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 17 deletions.
27 changes: 11 additions & 16 deletions packages/odyssey-storybook/applitools.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,21 @@
* See the License for the specific language governing permissions and limitations under the License.
*/

const VRT_IGNORE = "Toast.Provider Callout.Form Callout.Table".split(" ");
const branchName = process.env.GITHUB_HEAD_REF;
const parentBranchName = process.env.GITHUB_BASE_REF;
const shortCommitHash = process.env.GITHUB_SHA.slice(0, 7);

module.exports = {
// NOTE: the docs for this exitcode config are incorrect as of this
// writing. An explicit `false` value here allows a failed VRT run to
// exit non zero and our larger CI build to pass as we intend.
// Validating VRT results is then handled through a separate applitools
// github integration.
exitcode: true,

matchLevel: "Strict",
showStorybookOutput: true,
testConcurrency: 20,
browser: [{ width: 1024, height: 768, name: "chrome" }],
accessibilityValidation: {
level: "AA",
guidelinesVersion: "WCAG_2_1",
},
include({ name }) {
if (VRT_IGNORE.includes(name)) return false;
return true;
},
batchName: branchName?.concat(" ", shortCommitHash),
branchName,
browser: [{ width: 1024, height: 768, name: "chrome" }],
exitcode: true,
matchLevel: "Strict",
parentBranchName,
showStorybookOutput: true,
testConcurrency: 20,
};
2 changes: 1 addition & 1 deletion packages/odyssey-storybook/applitools.xbrowser.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ const config = require("./applitools.config");
module.exports = Object.assign(config, {
batch: {
name: "okta/odyssey: x-browser",
sequenceName: "x-browser",
notifyOnCompletion: true,
sequenceName: "x-browser",
},
browser: [
{ width: 1024, height: 768, name: "edgechromium" },
Expand Down

0 comments on commit 4c96f48

Please sign in to comment.