[WIP] Upgrading the DatePicker #1933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge v0.24.0 into develop
Initialize Tokens 2.0
chore(odyssey-react-mui): translations for odyssey-react-mui.properties
…theme fix: use odyssey tokens inside mui components style override
Rebrand: Link
refactor(odyssey-react-mui): migrate Circular Progress to design tokens
fix: added incremental to root TSconfig
…replace all touched tokens
fix: memoized the Link component
fix(odyssey-react-mui): make Autocomplete option styles match Select
…-MenuItem fix: add back isDisabled to MenuItem
…-MenuItem fix: remove useless isDestructive prop
Merge release/v1.0.2 into develop
Update MenuButton icon
Fix ARIA props on Typography component
feat: memoize Box and Typography
Master to Develop
fix: replace Select checkbox with MuiCheckbox
refactor(odyssey-react-mui): use IconButton within Form Fields
fix(odyssey-react-mui): ensure headings pick up TypographyFamilyHeading
* fix: move @emotion/styled and @emotion/react to dependencies * fix: update README installation instructions
* fix: add branches back to Applitools * chore: testing branch name logging * fix: removed explicit baseline * fix: updated Applitools branch name
|
You'll need to rebase from |
|
🤖 This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
🤖 This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to promote
DatePickerfrom Labs to Odyssey proper, now that the design is finished: https://www.figma.com/file/BH19N3gb6ovujMfRrTOH3r/Date-picker?type=design&node-id=10585-1233&mode=designThis involves several steps:
MuiDatePickerfrom v5 to v6 (https://mui.com/x/migration/migration-pickers-v5/)Upgrade from v5 to v6
I started the process of upgrading the MUI DatePicker from the old version to the latest, since this provides us with a bunch of nice features we need. Unfortunately it wasn't a smooth upgrade, and I had to spend some time figuring out which props and component/slot names changed. This guide was helpful.
Leverage Odyssey form fields
DatePickerallows us to swap in our own components, so I replaced the default DatePicker implementation with our own<TextField>. This gives us the correct label, hint, and error styles, as well as the ability to add our own Calendar button with Odyssey styles baked in.Some of this was hard to grok and I ran out of time to finish. The remaining tasks overlap with the next section on finalizing design implementation.
Finalize design implementation
Some assorted detail work here. I didn't get a chance to dig fully into this, but some tasks that will definitely need doing are:
refto work)Promote from Labs to Odyssey