Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds branches back to Applitools #1943

Merged
merged 4 commits into from
Aug 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions packages/odyssey-storybook/applitools.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,21 @@
* See the License for the specific language governing permissions and limitations under the License.
*/

const VRT_IGNORE = "Toast.Provider Callout.Form Callout.Table".split(" ");
const branchName = process.env.GITHUB_HEAD_REF;
const parentBranchName = process.env.GITHUB_BASE_REF;
const shortCommitHash = process.env.GITHUB_SHA.slice(0, 7);

module.exports = {
// NOTE: the docs for this exitcode config are incorrect as of this
// writing. An explicit `false` value here allows a failed VRT run to
// exit non zero and our larger CI build to pass as we intend.
// Validating VRT results is then handled through a separate applitools
// github integration.
exitcode: true,

matchLevel: "Strict",
showStorybookOutput: true,
testConcurrency: 20,
browser: [{ width: 1024, height: 768, name: "chrome" }],
accessibilityValidation: {
level: "AA",
guidelinesVersion: "WCAG_2_1",
},
include({ name }) {
if (VRT_IGNORE.includes(name)) return false;
return true;
},
batchName: branchName?.concat(" ", shortCommitHash),
branchName,
browser: [{ width: 1024, height: 768, name: "chrome" }],
exitcode: true,
matchLevel: "Strict",
parentBranchName,
showStorybookOutput: true,
testConcurrency: 20,
};
2 changes: 1 addition & 1 deletion packages/odyssey-storybook/applitools.xbrowser.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ const config = require("./applitools.config");
module.exports = Object.assign(config, {
batch: {
name: "okta/odyssey: x-browser",
sequenceName: "x-browser",
notifyOnCompletion: true,
sequenceName: "x-browser",
},
browser: [
{ width: 1024, height: 768, name: "edgechromium" },
Expand Down