Convert properties-to-ts to TypeScript #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGhadyani-Okta
requested review from
chrispulsinelli-okta and
queeniechen-okta
KevinGhadyani-Okta
requested review from
benschell-okta and
a team
as code owners
KevinGhadyani-Okta
force-pushed
the
kg/OKTA-691092
branch
from
09379dd
to
29975cb
Compare
KevinGhadyani-Okta
force-pushed
the
kg/OKTA-691092
branch
from
29975cb
to
2bade61
Compare
KevinGhadyani-Okta
force-pushed
the
kg/OKTA-691092
branch
from
046a8db
to
412d3c9
Compare
KevinGhadyani-Okta
force-pushed
the
kg/OKTA-691092
branch
from
a934fc1
to
699e565
Compare
KevinGhadyani-Okta
force-pushed
the
kg/OKTA-691092
branch
from
99c251f
to
32f4be9
Compare
chrispulsinelli-okta
approved these changes
Feb 16, 2024
benlister-okta
pushed a commit
that referenced
this pull request
Feb 20, 2024
* build: converts ts-node to tsx * build: updates properties-to-ts to use TypeScript * fix: exports FocusHandle from the correct location * fix: removes unused recursive-readdir * fix: minor refactor of filename in properties-to-ts * fix: refactored properties.d.ts using future PR with better code docs * fix: removed cyclical reference to icons index * fix: renamed variables in convertPropertiesToJson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-691092
Summary
Converts
properties-to-ts.jstoproperties-to-ts.ts. This allows us to check types on it just like any other file in the library.I also swapped out
ts-nodefortsxbecause I couldn't run this withts-node. In fact, it was giving a strange error of an unknown filetype.ts. Maybe a bad regex. Either way,tsxis the up 'n comer and worked great outta the box without any special configurations likets-node, so I included it as part of this PR.I verified both
ts-nodecommands work:generate:i18nandgenerate:iconsIndex.Testing & Screenshots
N/A