Additional refactoring for DataView #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/odyssey-react-mui/src/labs/DataComponents/TableSettings.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/TableSettings.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/TableSettings.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-mui/DataTable/DataTable.stories.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-mui/DataTable/DataTable.stories.tsx
Outdated
Show resolved
Hide resolved
|
@jordankoschei-okta Couple comments. Nothing major. Just an FYI, you've also got some dependency warnings that need fixed |
bryancunningham-okta
previously approved these changes
Jul 17, 2024
packages/odyssey-react-mui/src/labs/DataComponents/TableSettings.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/useFilterConversion.ts
Outdated
Show resolved
Hide resolved
KevinGhadyani-Okta
requested changes
Jul 17, 2024
packages/odyssey-react-mui/src/labs/DataComponents/TableSettings.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/TableSettings.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/TableSettings.tsx
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/labs/DataComponents/useFilterConversion.ts
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Outdated
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Outdated
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Outdated
Show resolved
Hide resolved
packages/odyssey-storybook/src/components/odyssey-labs/DataComponents/dataFunctions.ts
Outdated
Show resolved
Hide resolved
benlister-okta
previously approved these changes
Aug 6, 2024
KevinGhadyani-Okta
previously approved these changes
Aug 6, 2024
jordankoschei-okta
dismissed stale reviews from KevinGhadyani-Okta and benlister-okta
via
cf9191b
KevinGhadyani-Okta
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the outstanding code review from @KevinGhadyani-Okta on #2267, which we (intentionally) merged before fully refactoring.