Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: onAuthRequired to/from are backwards #22

Open
mattstrayer opened this issue Oct 10, 2018 · 0 comments
Open

Bug: onAuthRequired to/from are backwards #22

mattstrayer opened this issue Oct 10, 2018 · 0 comments

Comments

@mattstrayer
Copy link

The onAuthRequired function has the to and from variables referenced backwards. Vue Router middleware conforms to the (to, from next) pattern.
https://router.vuejs.org/guide/advanced/navigation-guards.html#global-guards

samples-js-vue/custom-login/src/router/index.js

Line 66 in 89baf66

const onAuthRequired = async (from, to, next) => {

mattstrayer pushed a commit to mattstrayer/samples-js-vue that referenced this issue Oct 18, 2018
🐛 Fixes order of onAuthRequired variables
d351403 
The to/from variables on the onAuthRequired function were backwards.

Resolves: okta#22
@mattstrayer mattstrayer mentioned this issue Oct 18, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattstrayer