Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okta_app_group_assignments - change group.profile to typeMap #1970

Open
exitcode0 opened this issue Apr 16, 2024 · 1 comment
Open

okta_app_group_assignments - change group.profile to typeMap #1970

exitcode0 opened this issue Apr 16, 2024 · 1 comment
Labels
enhancement Asking for new behavior or feature triaged Triaged into internal Jira

Comments

@exitcode0
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When using the okta_app_group_assignments the profile must be provided via a jsonencode({key = "value"})
I'm wondering if we can remove the need for jsonencode() completely in HCL
By moving group.profile to typeMap instead of TypeString we might be able to have the provider handle json encoding for the user automatically

New or Affected Resource(s)

  • okta_app_group_assignments

Potential Terraform Configuration

resource "okta_app_group_assignments" "example" {
  app_id = okta_app_saml.example.id

  group {
    id       = okta_group.example.id
    priority = 123
    profile  { role = "example" }
  }
}
resource "okta_app_group_assignments" "example" {
  app_id = okta_app_saml.example.id

  dynamic "group" {
    for_each = local.example
  
    content {
      id = each.value
      priority = each.key + 1
      profile {
        role = null
      }
    }
  }
}

References

@exitcode0 exitcode0 added the enhancement Asking for new behavior or feature label Apr 16, 2024
@duytiennguyen-okta duytiennguyen-okta added the triaged Triaged into internal Jira label Apr 16, 2024
@duytiennguyen-okta
Copy link
Contributor

OKTA internal reference https://oktainc.atlassian.net/browse/OKTA-720096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Asking for new behavior or feature triaged Triaged into internal Jira
Projects
None yet
Development

No branches or pull requests

2 participants