Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document manifest property dependencies.<item>.namespace #420

Open
andreafalzetti opened this issue Jun 12, 2023 · 11 comments · May be fixed by #857
Open

Document manifest property dependencies.<item>.namespace #420

andreafalzetti opened this issue Jun 12, 2023 · 11 comments · May be fixed by #857

Comments

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Jun 12, 2023

As per the title!

See: https://github.com/okteto/okteto/blob/master/pkg/model/manifest.go#L1002

@andreafalzetti andreafalzetti added the good first issue Good for newcomers label Jun 12, 2023
@aroramrinaal
Copy link

hey @andreafalzetti ,
I would like to work on this good-first-issue.

@andreafalzetti
Copy link
Contributor Author

Thanks for the interest @aroramrinaal - feel free to start on this. If you need support, don't hesitate to reach out :)

@ArslanYM
Copy link

Is this issue still open?

@andreafalzetti
Copy link
Contributor Author

@ArslanYM yes, it is

@ArslanYM
Copy link

ArslanYM commented Aug 3, 2023

Can I work on this?

@andreafalzetti
Copy link
Contributor Author

@ArslanYM thanks for offering your help, the docs repo is this one: https://github.com/okteto/docs

if you need any context or help, let me know

thanks!

@ArslanYM
Copy link

ArslanYM commented Aug 4, 2023

Can you give some context about the issue and how to approach this?

@andreafalzetti
Copy link
Contributor Author

Can you give some context about the issue and how to approach this?

This is a docs issue, so it would require understanding what property we're documenting here. The namespace of a dependency allows deploying a dependency in a different namespace. It's not the most common scenario but it's a use case that exists. At the moment namespace is not mentioned in docs: https://www.okteto.com/docs/reference/manifest/#dependencies-string-optional

As part of this ticket we can add it to the docs

@UtkarshUmre
Copy link

Is this issue still open?

@andreafalzetti andreafalzetti removed the good first issue Good for newcomers label Nov 30, 2023
@seanson
Copy link

seanson commented Sep 29, 2024

Definitely still an issue as the Manifest documentation still gives the type as an optional list of strings and there are quite a few properties available but only documented above as an "extended notation".

https://github.com/okteto/okteto/blob/18ce425b3e1a51da6a345c38dc391ac1fd21fd16/pkg/deps/deps.go#L31

@seanson
Copy link

seanson commented Sep 29, 2024

Apologies, as a followup: It looks like Namespace itself is going to be removed in the upcoming 3.x branch, but still exists in the 2.31.0 release. I think it would still be worth documenting as part of the whole resource though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants