Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary *Ref element for Fragment definitions. #1653

Closed
oleg-shilo opened this issue Oct 5, 2024 · 0 comments
Closed

Avoid unnecessary *Ref element for Fragment definitions. #1653

oleg-shilo opened this issue Oct 5, 2024 · 0 comments

Comments

@oleg-shilo
Copy link
Owner

Discussed in #1639

Originally posted by Lindsay-Mathieson September 15, 2024
Have the main installer sorted - does my desktop app and service ...

The discussion helped to identify the issue with the XML root Fragment elements (e.g. DotNetCompatibilityCheck) failing because of the unconditional *Ref element being inserted in the XML doc while it's only required for the non-root elements.

In the future even more explicit control might be required over project.AddWixFragment(...) but until the need is detected/confirmed a simple conditional auto-insert for *Ref is sufficient.

@oleg-shilo oleg-shilo changed the title Avoid unnessesary *Ref element for Fragment definitions. Avoid unnecessary *Ref element for Fragment definitions. Oct 5, 2024
oleg-shilo added a commit that referenced this issue Oct 5, 2024
- #1652: Bundle DotNetCompatibilityCheck element suport
- #1653: Avoid unnecessary *Ref element for Fragment definitions.
- #1579: installDir variable erased depending on ManagedProject structure
- Updated custom dialogs to deal with changes in the size of Wix stock background images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant