From 98f67ad99f83dbeadf6b0762b4b9fda07ba5f860 Mon Sep 17 00:00:00 2001 From: Leonardo Lima Date: Thu, 6 Jun 2024 16:50:06 -0300 Subject: [PATCH] fix(ci): remove usage of `bitcoin/no-std` feature - remove comment: `# The `no-std` feature it's implied when the `std` feature is disabled.` --- .github/workflows/cont_integration.yml | 10 +++++----- crates/bitcoind_rpc/Cargo.toml | 1 - crates/chain/Cargo.toml | 1 - crates/esplora/Cargo.toml | 1 - 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/workflows/cont_integration.yml b/.github/workflows/cont_integration.yml index 0b853b8de9..510af1dbfa 100644 --- a/.github/workflows/cont_integration.yml +++ b/.github/workflows/cont_integration.yml @@ -58,15 +58,15 @@ jobs: - name: Check bdk_chain working-directory: ./crates/chain # TODO "--target thumbv6m-none-eabi" should work but currently does not - run: cargo check --no-default-features --features bitcoin/no-std,miniscript/no-std,hashbrown + run: cargo check --no-default-features --features miniscript/no-std,hashbrown - name: Check bdk wallet working-directory: ./crates/wallet # TODO "--target thumbv6m-none-eabi" should work but currently does not - run: cargo check --no-default-features --features bitcoin/no-std,miniscript/no-std,bdk_chain/hashbrown + run: cargo check --no-default-features --features miniscript/no-std,bdk_chain/hashbrown - name: Check esplora working-directory: ./crates/esplora # TODO "--target thumbv6m-none-eabi" should work but currently does not - run: cargo check --no-default-features --features bitcoin/no-std,miniscript/no-std,bdk_chain/hashbrown + run: cargo check --no-default-features --features miniscript/no-std,bdk_chain/hashbrown check-wasm: name: Check WASM @@ -92,10 +92,10 @@ jobs: uses: Swatinem/rust-cache@v2.2.1 - name: Check bdk wallet working-directory: ./crates/wallet - run: cargo check --target wasm32-unknown-unknown --no-default-features --features bitcoin/no-std,miniscript/no-std,bdk_chain/hashbrown,dev-getrandom-wasm + run: cargo check --target wasm32-unknown-unknown --no-default-features --features miniscript/no-std,bdk_chain/hashbrown,dev-getrandom-wasm - name: Check esplora working-directory: ./crates/esplora - run: cargo check --target wasm32-unknown-unknown --no-default-features --features bitcoin/no-std,miniscript/no-std,bdk_chain/hashbrown,async + run: cargo check --target wasm32-unknown-unknown --no-default-features --features miniscript/no-std,bdk_chain/hashbrown,async fmt: name: Rust fmt diff --git a/crates/bitcoind_rpc/Cargo.toml b/crates/bitcoind_rpc/Cargo.toml index ae7a5e86bc..1652f1f83c 100644 --- a/crates/bitcoind_rpc/Cargo.toml +++ b/crates/bitcoind_rpc/Cargo.toml @@ -13,7 +13,6 @@ readme = "README.md" # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html [dependencies] -# The `no-std` feature it's implied when the `std` feature is disabled. bitcoin = { version = "0.32.0", default-features = false } bitcoincore-rpc = { version = "0.19.0" } bdk_chain = { path = "../chain", version = "0.15", default-features = false } diff --git a/crates/chain/Cargo.toml b/crates/chain/Cargo.toml index 8af2ce2efb..8b4a3c3286 100644 --- a/crates/chain/Cargo.toml +++ b/crates/chain/Cargo.toml @@ -13,7 +13,6 @@ readme = "README.md" # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html [dependencies] -# The `no-std` feature it's implied when the `std` feature is disabled. bitcoin = { version = "0.32.0", default-features = false } serde_crate = { package = "serde", version = "1", optional = true, features = ["derive", "rc"] } diff --git a/crates/esplora/Cargo.toml b/crates/esplora/Cargo.toml index 6bde474e5b..69339e8915 100644 --- a/crates/esplora/Cargo.toml +++ b/crates/esplora/Cargo.toml @@ -17,7 +17,6 @@ esplora-client = { version = "0.8.0", default-features = false } async-trait = { version = "0.1.66", optional = true } futures = { version = "0.3.26", optional = true } -# The `no-std` feature it's implied when the `std` feature is disabled. bitcoin = { version = "0.32.0", optional = true, default-features = false } miniscript = { version = "12.0.0", optional = true, default-features = false }