From ab77af439c36dfe219f72b176b41e016ea0e918b Mon Sep 17 00:00:00 2001 From: Parham Alvani Date: Thu, 21 Feb 2019 18:54:11 +0330 Subject: [PATCH] Tile38 support (#234) * Adds tile38 metrics and parser. --- .circleci/config.yml | 1 + exporter/redis.go | 45 ++++++++++++++++++++++++++++++++++++++++++ exporter/redis_test.go | 24 ++++++++++++++++++++++ 3 files changed, 70 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 8e4073a8..0f974e2c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -10,6 +10,7 @@ jobs: - image: redis:5 command: --port 6380 - image: grokzen/redis-cluster + - image: tile38/tile38:latest working_directory: /go/src/github.com/oliver006/redis_exporter steps: diff --git a/exporter/redis.go b/exporter/redis.go index 0e446228..651df44c 100644 --- a/exporter/redis.go +++ b/exporter/redis.go @@ -139,6 +139,26 @@ var ( // # Cluster "cluster_stats_messages_sent": "cluster_messages_sent_total", "cluster_stats_messages_received": "cluster_messages_received_total", + + // # Tile38 + // based on https://tile38.com/commands/server/ + "aof_size": "aof_size_bytes", + "avg_item_size": "avg_item_size_bytes", + "cpus": "cpus_total", + "heap_released": "heap_released_bytes", + "heap_size": "heap_size_bytes", + "http_transport": "http_transport", + "in_memory_size": "in_memory_size_bytes", + "max_heap_size": "max_heap_size_bytes", + "mem_alloc": "mem_alloc_bytes", + "num_collections": "num_collections_total", + "num_hooks": "num_hooks_total", + "num_objects": "num_objects_total", + "num_points": "num_points_total", + "pointer_size": "pointer_size_bytes", + "read_only": "read_only", + "threads": "threads_total", + "version": "version", // since tile38 version 1.14.1 } instanceInfoFields = map[string]bool{"role": true, "redis_version": true, "redis_build_id": true, "redis_mode": true, "os": true} @@ -491,6 +511,23 @@ func extractConfigMetrics(config []string, addr string, alias string, scrapes ch return } +func (e *Exporter) extractTile38Metrics(info []string, addr string, alias string, scrapes chan<- scrapeResult) error { + for i := 0; i < len(info); i += 2 { + log.Debugf("tile38: %s:%s", info[i], info[i+1]) + + fieldKey := info[i] + fieldValue := info[i+1] + + if !includeMetric(fieldKey) { + continue + } + + registerMetric(addr, alias, fieldKey, fieldValue, scrapes) + } + + return nil +} + func (e *Exporter) extractInfoMetrics(info, addr string, alias string, scrapes chan<- scrapeResult, dbCount int) error { var fieldClass string lines := strings.Split(info, "\r\n") @@ -887,6 +924,14 @@ func (e *Exporter) scrapeRedisHost(scrapes chan<- scrapeResult, addr string, idx e.extractInfoMetrics(infoAll, addr, e.redis.Aliases[idx], scrapes, dbCount) + // SERVER command only works on tile38 database. check the following link to + // find out more: https://tile38.com/ + if serverInfo, err := redis.Strings(doRedisCmd(c, "SERVER")); err == nil { + e.extractTile38Metrics(serverInfo, addr, e.redis.Aliases[idx], scrapes) + } else { + log.Debugf("Tile38 SERVER err: %s", err) + } + if reply, err := doRedisCmd(c, "LATENCY", "LATEST"); err == nil { var eventName string var spikeLast, milliseconds, max int64 diff --git a/exporter/redis_test.go b/exporter/redis_test.go index 9f118ea3..c9cec738 100644 --- a/exporter/redis_test.go +++ b/exporter/redis_test.go @@ -45,6 +45,7 @@ var ( listKeys = []string{} ts = int32(time.Now().Unix()) defaultRedisHost = RedisHost{} + defaultTileHost = RedisHost{Addrs: []string{":9851"}, Aliases: []string{"tile"}} dbNumStr = "11" altDBNumStr = "12" @@ -214,6 +215,29 @@ func TestLatencySpike(t *testing.T) { } } +func TestTile38(t *testing.T) { + e, _ := NewRedisExporter(defaultTileHost, "test", "", "") + + chM := make(chan prometheus.Metric) + go func() { + e.Collect(chM) + close(chM) + }() + + find := false + for m := range chM { + switch m := m.(type) { + case prometheus.Gauge: + if strings.Contains(m.Desc().String(), "cpus_total") { + find = true + } + } + } + if !find { + t.Errorf("cpus_total was not found in tile38 metrics") + } +} + func TestSlowLog(t *testing.T) { e, _ := NewRedisExporter(defaultRedisHost, "test", "", "")