Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Image Requires Recompilation To Use Different Olivia Client Backend #178

Open
bonedaddy opened this issue Jun 19, 2020 · 3 comments
Labels
kind:bug Something isn't working priority:medium
Milestone

Comments

@bonedaddy
Copy link

Unfortunately it seems like the docker image assumes a static port for the olivia backend. This makes using the docker image in different configurations a tedius task because you must either:

  • Use the port that is hard coded into the dockerfile
  • Recompile the docker image anytime you want to use a different port

In general it's good practice to not hard code these things and make it so that its configurable at run time, otherwise it is exceedingly difficult to make applications against the software.

@hugolgst
Copy link
Member

The port is nor hardcoded and can be easily changed.

@bonedaddy
Copy link
Author

Sorry if I was confusing, I didn't mean the port but the vue app url which doesnt appear to be configurable outside of a container image build

@hugolgst
Copy link
Member

Yes, you're right. I have to change that.

@hugolgst hugolgst added kind:bug Something isn't working priority:medium labels Oct 13, 2021
@hugolgst hugolgst added this to the 3.0.0 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working priority:medium
Projects
None yet
Development

No branches or pull requests

2 participants