Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible migration to compose multiplatform? #29

Open
rushiiMachine opened this issue Aug 16, 2023 · 3 comments
Open

Possible migration to compose multiplatform? #29

rushiiMachine opened this issue Aug 16, 2023 · 3 comments

Comments

@rushiiMachine
Copy link

Personally I love this library and use it in all of my projects however recently the question has come up of eventually support multiplatform (desktop, ios, etc.), however this does not. To my knowledge it wouldn't be difficult to migrate this library to KMP, (even more so given it doesn't use any platform apis..?)

I was curious if whether you would be interested in doing this or at least allowing a PR to support KMP.

@olshevski
Copy link
Owner

@rushiiMachine The core logic of the library is using just the Compose APIs. But what should be done about the Android architecture components (Lifecycle, ViewModels, SavedStateHandle) in KMP? They are platform-specific to Android. Should the library on iOS, Desktop, etc. just provide the navigation functionality without this features?

I didn't have a chance to work with KMP and Compose Multiplatform, so my current knowledge of the requirements for such a multiplatform library is lacking.

@olshevski
Copy link
Owner

@rushiiMachine Ok, since Compose for iOS finally reached beta, I feel like learning Compose Multiplatform is inevitable. I need to look into it.

@jershell
Copy link

@rushiiMachine The core logic of the library is using just the Compose APIs. But what should be done about the Android architecture components (Lifecycle, ViewModels, SavedStateHandle) in KMP? They are platform-specific to Android. Should the library on iOS, Desktop, etc. just provide the navigation functionality without this features?

I didn't have a chance to work with KMP and Compose Multiplatform, so my current knowledge of the requirements for such a multiplatform library is lacking.

Today CMP support viewModels, Lifecycle and SavedStateHandle. And targes as webJs and wasm reached alpha. Also webkit support wasmgc that means wpa on compose will replace clip\instant apps very well. Good point for support cmp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants