Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Going out of sync! #5

Closed
omarcostahamido opened this issue Oct 5, 2022 · 7 comments · Fixed by #38
Closed

Going out of sync! #5

omarcostahamido opened this issue Oct 5, 2022 · 7 comments · Fixed by #38
Assignees
@KaneBetter
Labels
HIGH high priority
Milestone
#4 MSWE first wor...

Comments

@omarcostahamido
Copy link
Owner

omarcostahamido commented Oct 5, 2022 •
edited
Loading

under some circumstance devices, that have been triggered to start at the same time, go out of sync.
@gggfffsss was this still happening with the latest version?
This issue needs to be further investigated... and, it is still happening, it needs to be fixed.

Adding some more context:

  • @gggfffsss confirmed that often times, but not consistently, frames are skipped during the first few seconds of starting to play a clip.
  • we've noticed that it happens less often when playback speed is less than normal speed (1.0).
  • one of the previous workarounds used was forcing all devices to go to clip position 0 every x minutes. This is what is currently achieved with the top right portion of the pvm.maxpat control patch.
  • another workaround was to start devices to play clips at a speed slower than normal speed (< 1.0) and progressively increase their speed up to normal speed in x number of steps during y seconds. This is what is currently achieved with the bottom right portion of the pvm.maxpat control patch.
@omarcostahamido omarcostahamido added the MID mid priority label Oct 5, 2022
@omarcostahamido
Copy link
Owner Author

Issue #11 is focusing on the buffer deadlock problem which might be what causes the videos to go out of sync.

omarcostahamido added a commit that referenced this issue Oct 24, 2022
@omarcostahamido
Create #5.maxpat
8ed162f 
- example with: different speeds in 4 devices
omarcostahamido added a commit that referenced this issue Oct 25, 2022
@omarcostahamido
Creative examples (#24)
eb5ee09 
- this fixes #22 

* Create examples.maxproj

* Create #1.maxpat

- example with: sync video in 2 devices

* Create #2.maxpat

- example with: sync video in 4 devices

* Create #3.maxpat

- example with: offset video in 2 devices

* Create #4.maxpat

- example with: offset video in 4 devices

* Create #5.maxpat

- example with: different speeds in 4 devices

* create examples index patch

* add `Examples` section

- in order to mention the examples folder and how to use it.
@omarcostahamido
Copy link
Owner Author

@SSSSam141 I know you focused on the buffer deadlock issue, which could be the reason for things going out of sync. In any case, I would like to ask you to confirm that synced videos is really no longer an issue and that omxplayer has solved it all. Best way to confirm that could be with the newly added examples, I would suggest 😉
If all is good in this domain then this issue could be closed.

KaneBetter pushed a commit that referenced this issue Oct 27, 2022
@omarcostahamido @KaneBetter
Creative examples (#24)
3d3f663 
- this fixes #22 

* Create examples.maxproj

* Create #1.maxpat

- example with: sync video in 2 devices

* Create #2.maxpat

- example with: sync video in 4 devices

* Create #3.maxpat

- example with: offset video in 2 devices

* Create #4.maxpat

- example with: offset video in 4 devices

* Create #5.maxpat

- example with: different speeds in 4 devices

* create examples index patch

* add `Examples` section

- in order to mention the examples folder and how to use it.
@KaneBetter
Copy link
Collaborator

Find some projects for sync omxplayer.
https://github.com/turingmachine/omxplayer-sync
https://github.com/bmoren/node-omxplayer-sync

@omarcostahamido
Copy link
Owner Author

omarcostahamido commented Oct 31, 2022 •
edited
Loading

woah, thank you for finding those @KaneBetter !
I'm boosting this issue to HIGH. I'd love to see this being closed next, before the dual screen issue which will bring added complexity here.
take it away!

@omarcostahamido omarcostahamido added HIGH high priority and removed MID mid priority labels Oct 31, 2022
@KaneBetter
Copy link
Collaborator

woah, thank you for finding those @KaneBetter ! I'm boosting this issue to HIGH. I'd love to see this being closed next, before the dual screen issue which will bring added complexity here. take it away!

We still need to reproduce this issue first. Maybe this issue doesn't exist in OMXPlayer.
If this issue does exist, we have two options to choose from.
One is to send a timestamp with the start function.
Two is to let each Raspberry Pi talk to the other.

@KaneBetter
Copy link
Collaborator

It seems omxplayer and python processes themselves run smoothly in each RPI. The average time for the system to execute the command is 70ms.
We also observed this issue #35 in our tests. So we think bringing this #35 up is an excellent solution.

@KaneBetter KaneBetter self-assigned this Nov 13, 2022
@KaneBetter KaneBetter mentioned this issue Nov 16, 2022
Merged
@KaneBetter
Copy link
Collaborator

#38 fixes this.

omarcostahamido added a commit that referenced this issue Mar 26, 2023
@omarcostahamido
Update #5.maxpat
0814cdb 
- change `pattern01_prores422.mov` to `pattern01_h264.mov`
- this refers to #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaneBetter KaneBetter

Labels
HIGH high priority
Projects
None yet
Milestone
#4 MSWE first working beta
Development

Successfully merging a pull request may close this issue.

Add timestamps to pvm_send abstraction and pvm.py omarcostahamido/PVM
2 participants
@omarcostahamido @KaneBetter