Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X arm64 support (jna dependency) #16

Open
sbesson opened this issue Mar 14, 2022 · 0 comments
Open

OS X arm64 support (jna dependency) #16

sbesson opened this issue Mar 14, 2022 · 0 comments

Comments

@sbesson
Copy link
Member

sbesson commented Mar 14, 2022

Testing the command-line workflow on a local Macbook Pro with Apple M1 chip, running

(java_dev) sbesson@Sebastiens-MacBook-Pro bftools %  BF_CP=~/Downloads/OMEZarrReader-0.1.1-jar-with-dependencies.jar ./showinf ~/Desktop/embl/cyx.ome.zarr/.zattrs -noflat -autoscale

fails with

Exception in thread "main" java.lang.UnsatisfiedLinkError: /private/var/folders/jj/nbnt8dds4yjbyv02whgbl9_h0000gn/T/jna-1886180661/jna4844027533235729477.tmp: dlopen(/private/var/folders/jj/nbnt8dds4yjbyv02whgbl9_h0000gn/T/jna-1886180661/jna4844027533235729477.tmp, 0x0001): tried: '/private/var/folders/jj/nbnt8dds4yjbyv02whgbl9_h0000gn/T/jna-1886180661/jna4844027533235729477.tmp' (fat file, but missing compatible architecture (have 'i386,x86_64', need 'arm64e')), '/usr/local/lib/jna4844027533235729477.tmp' (no such file), '/usr/lib/jna4844027533235729477.tmp' (no such file)
	at java.base/java.lang.ClassLoader$NativeLibrary.load0(Native Method)
	at java.base/java.lang.ClassLoader$NativeLibrary.load(ClassLoader.java:2442)
	at java.base/java.lang.ClassLoader$NativeLibrary.loadLibrary(ClassLoader.java:2498)
	at java.base/java.lang.ClassLoader.loadLibrary0(ClassLoader.java:2694)
	at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2627)
	at java.base/java.lang.Runtime.load0(Runtime.java:768)
	at java.base/java.lang.System.load(System.java:1837)
	at com.sun.jna.Native.loadNativeDispatchLibraryFromClasspath(Native.java:851)
	at com.sun.jna.Native.loadNativeDispatchLibrary(Native.java:826)
	at com.sun.jna.Native.<clinit>(Native.java:140)
	at com.sun.jna.NativeLong.<clinit>(NativeLong.java:23)
	at com.sun.jna.ptr.NativeLongByReference.<init>(NativeLongByReference.java:19)
	at com.bc.zarr.CompressorFactory$BloscCompressor.cbufferSizes(CompressorFactory.java:349)
	at com.bc.zarr.CompressorFactory$BloscCompressor.uncompress(CompressorFactory.java:338)
	at com.bc.zarr.chunk.ChunkReaderWriterImpl_Short.read(ChunkReaderWriterImpl_Short.java:55)
	at com.bc.zarr.ZarrArray.read(ZarrArray.java:278)
	at com.bc.zarr.ZarrArray.read(ZarrArray.java:255)
	at loci.formats.services.JZarrServiceImpl.readBytes(JZarrServiceImpl.java:268)
	at loci.formats.in.ZarrReader.openBytes(ZarrReader.java:410)
	at loci.formats.ImageReader.openBytes(ImageReader.java:465)
	at loci.formats.ReaderWrapper.openBytes(ReaderWrapper.java:348)
	at loci.formats.MinMaxCalculator.openBytes(MinMaxCalculator.java:269)
	at loci.formats.MinMaxCalculator.openBytes(MinMaxCalculator.java:260)
	at loci.formats.ReaderWrapper.openBytes(ReaderWrapper.java:334)
	at loci.formats.tools.ImageInfo.readPixels(ImageInfo.java:825)
	at loci.formats.tools.ImageInfo.testRead(ImageInfo.java:1055)
	at loci.formats.tools.ImageInfo.main(ImageInfo.java:1121)

This is primarily due to the fact that the version of jna

(java_dev) sbesson@Sebastiens-MacBook-Pro ZarrReader % mvn dependency:tree | grep jna
[INFO] |     \- net.java.dev.jna:jna:jar:4.2.2:compile

does not include support for arm64 architecture on OSX

(java_dev) sbesson@Sebastiens-MacBook-Pro ZarrReader % tar tf ~/.m2/repository/net/java/dev/jna/jna/4.2.2/jna-4.2.2.jar | grep darwin
com/sun/jna/darwin/
com/sun/jna/darwin/libjnidispatch.jnilib

Locally overriding the jna version to use the most recent release

diff --git a/pom.xml b/pom.xml
index 67d40e8..703e680 100644
--- a/pom.xml
+++ b/pom.xml
@@ -56,6 +56,12 @@
   </pluginRepositories>
 
   <dependencies>
+    <dependency>
+      <groupId>net.java.dev.jna</groupId>
+      <artifactId>jna</artifactId>
+      <version>5.10.0</version>
+    </dependency>
 
     <dependency>
       <groupId>com.bc.zarr</groupId>

is sufficient to fix the issue since the JAR includes the libraries for the architecture. Is it worth opening the changes above as a PR for now and/or start engaging the conversation upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant