Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularised run-scripts #6

Open
dpwrussell opened this issue Apr 3, 2017 · 5 comments
Open

Modularised run-scripts #6

dpwrussell opened this issue Apr 3, 2017 · 5 comments

Comments

@dpwrussell
Copy link
Member

Thoughts on modularising the runscripts?

Currently I can not make use of the run script at all because there are several points at which I need to run custom configuration. If the run.sh was just an entry point which executes some other scripts then my run.sh would be much simpler, a copy of the list of script executions with some new ones interspersed.

@joshmoore
Copy link
Member

WFM.

@manics
Copy link
Member

manics commented Apr 4, 2017

Can you outline how you'd break the current run.sh script down? Some of that work may overlap with refactoring omego, e.g. making it easier to run separate steps instead of an all-in-one install/upgrade. Related:

Most of the logic in https://github.com/openmicroscopy/omero-grid-docker/blob/master/omero-grid/run.sh is to modify the templates for a multi-container omero-grid setup, and should really be supported by OMERO.server directly.

@dpwrussell
Copy link
Member Author

In very rough terms here is how I imagine it, including examples from my use case of a customization.

  • Default master script executing others and some variable defaults.
  • Example: Check and if necessary change filesystem permissions of filesystems
  • Wait for postgres connection
  • Example: Get database from S3 if a certain variable is set
  • Install database (Example: Restore database instead of a certain variable is set)
  • Grid stuff (so that when this is not needed, the config is much simpler)
  • Load config files if present
  • Example: Configure public-user
  • Example: Sync data necessary to start the server from S3 if a certain variable is set
  • Example: Begin Syncing data in foreground or background (depending on another certain variable) not necessary to start the server from S3 if a certain variable is set
  • Example: Start omero in the foreground

@manics
Copy link
Member

manics commented Apr 5, 2017

Perhaps the run scripts should be completely separate from this repo? I could see them being used for OMERO cloud-images as well as Docker.

@dpwrussell
Copy link
Member Author

That could make sense. Then the docker image would install those as part of its build. This would also work well for building several different dockers, e.g. monolith-omero images in addition to the separated components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants