Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletemap subcommand: proposed renaming and default behavior #12

Open
sbesson opened this issue Sep 20, 2018 · 1 comment
Open

Deletemap subcommand: proposed renaming and default behavior #12

sbesson opened this issue Sep 20, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@sbesson
Copy link
Member

sbesson commented Sep 20, 2018

See #11 (comment)

There is some known variation between the various context classes invoked by metadata populate --context. Although the signatures of the constructor is maintained in sync, many of the options are really targetted at one context only.

DeleteMapAnnotationContext is probably the most obvious example. Unlike the other contexts, it uses the loops and ms options for the graph operation on the server. In addition, populate --context deletemap feels a bit contradictory from a semantic perspective.

A proposal would be to:

  • separate the DeleteMapAnnotationContext API the other population contexts, eventually migrating it to a separate module
  • deprecate metadata populate --context deletemap and replace it by a more explicit metadata delete subcommdn (maybe even metadata delete --bulkmap to mirror the populate command)
  • fix the default deletion command behavior to properly handle infinite waiting
@joshmoore
Copy link
Member

metadata delete is sufficiently broad that it might help to drive the renaming here. e.g.: bulkmap delete and mapannotation delete or metadata delete maps etc.

@sbesson sbesson added the enhancement New feature or request label Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants