Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: add --ignore-status label/filter #261

Open
manics opened this issue Jan 22, 2020 · 3 comments
Open

RFE: add --ignore-status label/filter #261

manics opened this issue Jan 22, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@manics
Copy link
Member

manics commented Jan 22, 2020

Allow PRs to be included regardless of their travis status by adding a new label/filter.

@sbesson sbesson added the enhancement New feature or request label Mar 3, 2020
@sbesson
Copy link
Member

sbesson commented May 8, 2020

I would have expected scc merge -S none to work for this. Can you expand on the type of scenario that you are looking into?

@sbesson sbesson added the question Further information is requested label May 8, 2020
@manics
Copy link
Member Author

manics commented May 18, 2020

-S none will merge all PRs regardless of status, the idea here is to allow individual PRs to be whitelisted, for example so that multiple dependent PRs can be included in a daily merge-all-PRs build without having to add workarounds in each PR to get Travis to pass.

@sbesson sbesson removed the question Further information is requested label May 23, 2020
@sbesson
Copy link
Member

sbesson commented May 23, 2020

Understood. For PR-specific behavior, some detection logic would need to be inserted before:

scc/scc/git.py

Lines 988 to 990 in 81babbc

status = pullrequest.get_last_status("base")
if status is None:

to compare the labels and/or using the PullRequest.parse() API if we want to allow the status to be ignored via description/comment:

scc/scc/git.py

Lines 949 to 951 in 81babbc

if pullrequest.parse(filters["exclude"].get("label"),
whitelist=is_whitelisted_comment):
return False, 'exclude comment'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants