Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes CI lint check #129

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix: Fixes CI lint check #129

merged 2 commits into from
Nov 22, 2023

Conversation

gruyaume
Copy link
Contributor

Description

This PR fixes the currently broken lint check. The linting tool couldn't run because of the whitespace key that was defined twice in .golangci.yml.

Note: This PR does not fix the linting itself, those would come in a subsequent PR. The first step is to have a working CI.

@onf-bot
Copy link
Contributor

onf-bot commented Oct 23, 2023

Can one of the admins verify this patch?

1 similar comment
@onf-bot
Copy link
Contributor

onf-bot commented Oct 23, 2023

Can one of the admins verify this patch?

@ghislainbourgeois
Copy link
Contributor

Duplicate of #127

@dafATonf
Copy link

retest this please

@dafATonf
Copy link

test this please

@thakurajayL
Copy link
Contributor

Please rebase your code.

@gab-arrobo
Copy link
Contributor

@dependabot rebase

@gab-arrobo
Copy link
Contributor

@gruyaume, please address issue with golangci-lint GHA

@gruyaume
Copy link
Contributor Author

This PR does not fix the linting itself, those would come in a subsequent PR. The first step is to have a working CI.

@gab-arrobo as mentioned in the PR description, "This PR does not fix the linting itself, those would come in a subsequent PR. The first step is to have a working CI." All we do here is un break the file that describes lint checks.

@gab-arrobo
Copy link
Contributor

This PR does not fix the linting itself, those would come in a subsequent PR. The first step is to have a working CI.

@gab-arrobo as mentioned in the PR description, "This PR does not fix the linting itself, those would come in a subsequent PR. The first step is to have a working CI." All we do here is un break the file that describes lint checks.

Got it. Thanks!

@gab-arrobo
Copy link
Contributor

retest this please

@gab-arrobo gab-arrobo merged commit 9cd04c4 into omec-project:master Nov 22, 2023
6 of 7 checks passed
@isimluk isimluk mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatici gatici gatici approved these changes

@thakurajayL thakurajayL thakurajayL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gruyaume @onf-bot @ghislainbourgeois @dafATonf @thakurajayL @gab-arrobo @gatici