Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint GHA #21

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Add golangci-lint GHA #21

merged 2 commits into from
Sep 28, 2024

Conversation

gab-arrobo
Copy link
Contributor

@gab-arrobo gab-arrobo commented Sep 28, 2024 •
edited
Loading

For now, golangci-lint is ignoring the following files, which is something that needs to be addressed after the work for the 3GPP release upgrade is completed:

  skip-files:
    - "api_.*\\.go$"
    - "model_.*\\.go$"
    - "client.go"

Tested these changes with OnRamp using the replace directive in the smf pod/image

@gab-arrobo
Add golangci-lint GHA
4594df7 
Signed-off-by: Arrobo, Gabriel <[email protected]>
@gab-arrobo
Ignore configuration.go files
b40e732 
Signed-off-by: Arrobo, Gabriel <[email protected]>
@gab-arrobo gab-arrobo merged commit 7eb63af into omec-project:main Sep 28, 2024
6 checks passed
@gab-arrobo gab-arrobo deleted the golangci-lint-gha branch September 28, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thakurajayL thakurajayL thakurajayL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gab-arrobo @thakurajayL