Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable revive linter #89

Open
gab-arrobo opened this issue May 30, 2024 · 3 comments
Open

Enable revive linter #89

gab-arrobo opened this issue May 30, 2024 · 3 comments

Comments

@gab-arrobo
Copy link
Contributor

gab-arrobo commented May 30, 2024

With the goal of improving the code quality in this repo, it would be good to add the revive linter (as shown below) and properly add the documentation to the different functions

diff --git a/.golangci.yml b/.golangci.yml
index 357611a..4d11a06 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -239,6 +239,7 @@ linters:
     - typecheck
     # Additional
     # - lll
+    - revive
     - godox
     #- gomnd
     - goconst
@gab-arrobo
Copy link
Contributor Author

@ianchen0119 are you or someone you know available to help address this issue?

@ianchen0119
Copy link
Contributor

Hi @gab-arrobo
Would you happen to know if this task is urgent? if not, I can help.

@gab-arrobo
Copy link
Contributor Author

Hi @gab-arrobo Would you happen to know if this task is urgent? if not, I can help.

Hi @ianchen0119,
This is not an urgent task. Please feel free to work on it when you have a chance. After this is addressed, I can create a new tag/release for pfcpsim,
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants