From 74d1dc7fc1f827afcba365b2d6bfe24730fdc6bc Mon Sep 17 00:00:00 2001
From: Daniel Berthereau <Daniel.github@Berthereau.net>
Date: Fri, 25 May 2018 00:00:00 +0200
Subject: [PATCH] Used a class instead of a data to select values with batch
 process.

---
 application/asset/js/admin.js                      |  2 +-
 application/view/omeka/admin/item-set/browse.phtml | 10 +++++-----
 application/view/omeka/admin/item/browse.phtml     | 10 +++++-----
 application/view/omeka/admin/media/browse.phtml    | 10 +++++-----
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/application/asset/js/admin.js b/application/asset/js/admin.js
index 21a5bef3e3..25e3325c47 100644
--- a/application/asset/js/admin.js
+++ b/application/asset/js/admin.js
@@ -178,7 +178,7 @@ var Omeka = {
     },
 
     manageSelectedActions: function() {
-        var selectedOptions = $('#batch-form .batch-inputs [data-select=selected]');
+        var selectedOptions = $('#batch-form .batch-inputs .batch-selected');
         if ($('.batch-edit td input[type="checkbox"]:checked').length > 0) {
             selectedOptions.removeAttr('disabled');
         } else {
diff --git a/application/view/omeka/admin/item-set/browse.phtml b/application/view/omeka/admin/item-set/browse.phtml
index 25dce52208..f74598e929 100644
--- a/application/view/omeka/admin/item-set/browse.phtml
+++ b/application/view/omeka/admin/item-set/browse.phtml
@@ -45,13 +45,13 @@ $sortHeadings = [
     <div class="batch-inputs">
         <select class="batch-actions-select" name="batch_action" aria-label="<?php echo $this->translate('Batch actions'); ?>">
             <option value="default"><?php echo $this->translate('Batch actions'); ?></option>
-            <option value="update-selected" data-select="selected" disabled="disabled"><?php echo $this->translate('Edit selected'); ?></option>
-            <option value="update-all" data-select="all"><?php echo $this->translate('Edit all'); ?></option>
-            <option value="delete-selected" data-select="selected" disabled="disabled"><?php echo $this->translate('Delete selected'); ?></option>
-            <option value="delete-all" data-select="all"><?php echo $this->translate('Delete all'); ?></option>
+            <option value="update-selected" class="batch-selected" disabled><?php echo $this->translate('Edit selected'); ?></option>
+            <option value="update-all"><?php echo $this->translate('Edit all'); ?></option>
+            <option value="delete-selected" class="batch-selected" disabled><?php echo $this->translate('Delete selected'); ?></option>
+            <option value="delete-all"><?php echo $this->translate('Delete all'); ?></option>
         </select>
         <div class="batch-actions">
-            <button type="button" class="default active" disabled="disabled"><?php echo $this->translate('Go'); ?></button>
+            <button type="button" class="default active" disabled><?php echo $this->translate('Go'); ?></button>
             <input type="submit" class="update-selected" value="<?php echo $this->translate('Go'); ?>" formaction="<?php echo $escape($this->url(null, ['action' => 'batch-edit'], true)); ?>">
             <input type="submit" class="update-all" value="<?php echo $this->translate('Go'); ?>" formaction="<?php echo $escape($this->url(null, ['action' => 'batch-edit-all'], true)); ?>">
             <input type="hidden" name="query" class="batch-query" value="<?php echo $escape(json_encode($this->params()->fromQuery())); ?>">
diff --git a/application/view/omeka/admin/item/browse.phtml b/application/view/omeka/admin/item/browse.phtml
index 2cc5ca07ad..457b8d1a2f 100644
--- a/application/view/omeka/admin/item/browse.phtml
+++ b/application/view/omeka/admin/item/browse.phtml
@@ -44,13 +44,13 @@ $sortHeadings = [
     <div class="batch-inputs">
         <select class="batch-actions-select" name="batch_action" aria-label="<?php echo $this->translate('Batch actions'); ?>">
             <option value="default"><?php echo $this->translate('Batch actions'); ?></option>
-            <option value="update-selected" data-select="selected" disabled="disabled"><?php echo $this->translate('Edit selected'); ?></option>
-            <option value="update-all" data-select="all"><?php echo $this->translate('Edit all'); ?></option>
-            <option value="delete-selected" data-select="selected" disabled="disabled"><?php echo $this->translate('Delete selected'); ?></option>
-            <option value="delete-all" data-select="all"><?php echo $this->translate('Delete all'); ?></option>
+            <option value="update-selected" class="batch-selected" disabled><?php echo $this->translate('Edit selected'); ?></option>
+            <option value="update-all"><?php echo $this->translate('Edit all'); ?></option>
+            <option value="delete-selected" class="batch-selected" disabled><?php echo $this->translate('Delete selected'); ?></option>
+            <option value="delete-all"><?php echo $this->translate('Delete all'); ?></option>
         </select>
         <div class="batch-actions">
-            <button type="button" class="default active" disabled="disabled"><?php echo $this->translate('Go'); ?></button>
+            <button type="button" class="default active" disabled><?php echo $this->translate('Go'); ?></button>
             <input type="submit" class="update-selected" value="<?php echo $this->translate('Go'); ?>" formaction="<?php echo $escape($this->url(null, ['action' => 'batch-edit'], true)); ?>">
             <input type="submit" class="update-all" value="<?php echo $this->translate('Go'); ?>" formaction="<?php echo $escape($this->url(null, ['action' => 'batch-edit-all'], true)); ?>">
             <input type="hidden" name="query" class="batch-query" value="<?php echo $escape(json_encode($this->params()->fromQuery())); ?>">
diff --git a/application/view/omeka/admin/media/browse.phtml b/application/view/omeka/admin/media/browse.phtml
index 72bbf3e12b..824df6c5bd 100644
--- a/application/view/omeka/admin/media/browse.phtml
+++ b/application/view/omeka/admin/media/browse.phtml
@@ -41,16 +41,16 @@ $sortHeadings = [
         <select class="batch-actions-select" name="batch_action" aria-label="<?php echo $this->translate('Batch actions'); ?>">
             <option value="default"><?php echo $this->translate('Batch actions'); ?></option>
             <?php if ($userIsAllowedBatchUpdate): ?>
-            <option value="update-selected" data-select="selected" disabled="disabled"><?php echo $this->translate('Edit selected'); ?></option>
-            <option value="update-all" data-select="all"><?php echo $this->translate('Edit all'); ?></option>
+            <option value="update-selected" class="batch-selected" disabled><?php echo $this->translate('Edit selected'); ?></option>
+            <option value="update-all"><?php echo $this->translate('Edit all'); ?></option>
             <?php endif; ?>
             <?php if ($userIsAllowedBatchDelete): ?>
-            <option value="delete-selected" data-select="selected" disabled="disabled"><?php echo $this->translate('Delete selected'); ?></option>
-            <option value="delete-all" data-select="all"><?php echo $this->translate('Delete all'); ?></option>
+            <option value="delete-selected" class="batch-selected" disabled><?php echo $this->translate('Delete selected'); ?></option>
+            <option value="delete-all"><?php echo $this->translate('Delete all'); ?></option>
             <?php endif; ?>
         </select>
         <div class="batch-actions">
-            <button type="button" class="default active" disabled="disabled"><?php echo $this->translate('Go'); ?></button>
+            <button type="button" class="default active" disabled><?php echo $this->translate('Go'); ?></button>
             <?php if ($userIsAllowedBatchUpdate): ?>
             <input type="submit" class="update-selected" value="<?php echo $this->translate('Go'); ?>" formaction="<?php echo $escape($this->url(null, ['action' => 'batch-edit'], true)); ?>">
             <input type="submit" class="update-all" value="<?php echo $this->translate('Go'); ?>" formaction="<?php echo $escape($this->url(null, ['action' => 'batch-edit-all'], true)); ?>">