Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Bridges: Semi-automize process of registering NFT pairs #479

Open
wsdt opened this issue Mar 10, 2022 · 0 comments
Open

Bridges: Semi-automize process of registering NFT pairs #479

wsdt opened this issue Mar 10, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@wsdt
Copy link
Contributor

wsdt commented Mar 10, 2022

NOTE: Once you have your L2StandardERC721 address, please contact us so we can register that address in the L1 and L2 NFT bridges.

Gas on Boba is cheap, why not letting people register their NFT pairs directly on the bridge and Boba then simply has to approve the pairs afterwards:

E.g.:

 // Info of each NFT
    struct PairNFTInfo {
        address l1Contract;
        address l2Contract;
        Network baseNetwork; // L1 or L2
        bool approved; // default false
    }

So users can add their contracts here via external function and boba (onlyOwner) simply has to set the pair to approved = true.

Nevertheless, this could come with 2 risks:

  • We have to check if a pair is approved or not before using it otherwise revert.
  • Someone might spam the bridge with non-approved entries (around 10 million entries might be saved and then older entries get overriden).

Curious to know what you think and if this has more advantages than disadvantages in your opinion! :-)

@wsdt wsdt added the enhancement New feature or request label Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants