Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade relayer/monitor to use gRPC cprovider #2252

Closed
corverroos opened this issue Oct 23, 2024 · 0 comments
Closed

Upgrade relayer/monitor to use gRPC cprovider #2252

corverroos opened this issue Oct 23, 2024 · 0 comments
Assignees
@corverroos
Labels
sprint: ad hoc PRs or issues included mid-sprint

Comments

@corverroos
Copy link
Collaborator

Problem to Solve

We have added support for gRPC state queries in halo. Relayer and monitor are however still using the legacy CometBFT RPC. We should upgrade them to using gRPC instead.

Proposed Solution

  • Ensure that the gRPC port is accessible to the internal network in e2e.
  • Add a --halo-grpc-url flag to relayer and monitor config.
  • Wire relayer and monitor to with associated grpc endpoints.
  • Add newCProvider method that returns either gRPC otherwise Comet based impl. See halo/app/start.go.
@corverroos corverroos added the sprint: ad hoc PRs or issues included mid-sprint label Oct 23, 2024
@fabtreb fabtreb removed this from the c1.1 - Mainnet Beta [Dec 11] milestone Dec 6, 2024
@corverroos corverroos self-assigned this Jan 14, 2025
@corverroos corverroos mentioned this issue Jan 14, 2025
Merged
corverroos added a commit that referenced this issue Jan 21, 2025
@corverroos
chore(relayer): use halo gRPC cprovider (#2797)
0e84737 
Switch relayer to use halo gRPC CProvider for improved performance.

issue: #2252
@corverroos corverroos mentioned this issue Jan 21, 2025
Merged
corverroos added a commit that referenced this issue Jan 22, 2025
@corverroos
chore(monitor): use grpc cprovider (#2845)
6d7c3ec 
Switch monitor to gRPC (relayer already done).

issue: #2252
@fabtreb fabtreb closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
sprint: ad hoc PRs or issues included mid-sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corverroos @fabtreb