Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subclassing Connection #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PikalaxALT
Copy link

Description

Add cls kwarg to core.connect that is a subclass or Connection (or a Callable[[Callable[[Any], sqlite3.Connection], int], Connection]) (default: Connection)

Example usage:

class MyConnection(aiosqlite.Connection):
    ...

async def main():
    conn = await aiosqlite.connect(':memory:', cls=MyConnection)
    # use methods and attrs of MyConnection

Current workaround: connect must be redefined to explicitly call your custom async connection factory.

Add `cls` kwarg to `core.connect` that is a subclass or Connection (or a `Callable[[Callable[[Any], sqlite3.Connection], int], Connection]`) (default: `Connection`)
@amyreese
Copy link
Member

Sounds good. Can you add a simple test case covering this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants