Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unzip doesn't work with certain zip archives #3448

Closed
rmustacc opened this issue Jan 23, 2024 · 0 comments · Fixed by #3449
Closed

unzip doesn't work with certain zip archives #3448

rmustacc opened this issue Jan 23, 2024 · 0 comments · Fixed by #3449
Assignees
@citrus-it
Labels
bug

Comments

@rmustacc
Copy link

When taking a hubris archive built on a system like Linux, unzip does not work on the archive as files are skipped due to PKZIP 4.6 compatibility issues:

Archive:  ./gimlet-c71-build-gimlet.zip
hubris build archive v8
   skipping: README.TXT              need PK compat. v4.6 (can do v4.5)
   skipping: git-rev                 need PK compat. v4.6 (can do v4.5)
   skipping: image-name              need PK compat. v4.6 (can do v4.5)
   skipping: app.toml                need PK compat. v4.6 (can do v4.5)
   skipping: chip.toml               need PK compat. v4.6 (can do v4.5)
   skipping: memory.toml             need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/jefe           need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/net            need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/sys            need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/spi2_driver    need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/i2c_driver     need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/spd            need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/packrat        need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/thermal        need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/power          need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/hiffy          need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/gimlet_seq     need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/hash_driver    need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/hf             need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/update_server  need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/sensor         need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/host_sp_comms  need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/udpecho        need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/udpbroadcast   need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/control_plane_agent  need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/sprot          need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/validate       need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/vpd            need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/user_leds      need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/dump_agent     need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/sbrmi          need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/idle           need PK compat. v4.6 (can do v4.5)
   skipping: elf/task/udprpc         need PK compat. v4.6 (can do v4.5)
   skipping: elf/kernel              need PK compat. v4.6 (can do v4.5)
   skipping: img/flash.ron           need PK compat. v4.6 (can do v4.5)
   skipping: debug/script.gdb        need PK compat. v4.6 (can do v4.5)
   skipping: debug/openocd.cfg       need PK compat. v4.6 (can do v4.5)
   skipping: debug/openocd.gdb       need PK compat. v4.6 (can do v4.5)
   skipping: task/gimlet_seq/gimlet-regs-b.json  need PK compat. v4.6 (can do v4.5)
   skipping: img/final.bin           need PK compat. v4.6 (can do v4.5)
   skipping: img/final.elf           need PK compat. v4.6 (can do v4.5)
   skipping: img/final.fwid          need PK compat. v4.6 (can do v4.5)

From discussion with others, it's suggested that we're missing bzip2 support. While we have the IZ_BZIP2=bzip2 file in the MAKE_ARGS variable, I do see others using a -DUSE_BZIP2 in the debian rules at https://sources.debian.org/src/unzip/6.0-28/debian/rules/#L10-L13.
citrus-it added a commit to citrus-it/omnios-build that referenced this issue Jan 23, 2024
@citrus-it
unzip was not building with bzip2 support
ecd23f1 
This appears to have begun at the point that we stopped
shipping the static libbz2.a.

Fixes: omniosorg#3448
@citrus-it citrus-it self-assigned this Jan 23, 2024
@citrus-it citrus-it added the bug label Jan 23, 2024
@citrus-it citrus-it linked a pull request Jan 23, 2024 that will close this issue
unzip was not building with bzip2 support #3449
Merged
citrus-it added a commit to citrus-it/omnios-build that referenced this issue Jan 23, 2024
@citrus-it
unzip was not building with bzip2 support
15efc4f 
This appears to have begun at the point that we stopped
shipping the static libbz2.a.

Fixes: omniosorg#3448
citrus-it added a commit to citrus-it/omnios-build that referenced this issue Jan 23, 2024
@citrus-it
unzip was not building with bzip2 support
251d417 
This appears to have begun at the point that we stopped
shipping the static libbz2.a.

Fixes: omniosorg#3448
citrus-it added a commit to oxidecomputer/helios-omnios-build that referenced this issue Jan 25, 2024
@citrus-it
unzip was not building with bzip2 support
58b34d3 
This appears to have begun at the point that we stopped
shipping the static libbz2.a.

Fixes: omniosorg/omnios-build#3448
citrus-it added a commit to oxidecomputer/helios-omnios-build that referenced this issue Jan 29, 2024
@citrus-it
Unzip was not building with bzip2 support (#18)
68b2a6e 
* unzip was not building with bzip2 support

This appears to have begun at the point that we stopped
shipping the static libbz2.a.

Fixes: omniosorg/omnios-build#3448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@citrus-it citrus-it

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unzip was not building with bzip2 support citrus-it/omnios-build
2 participants
@rmustacc @citrus-it