Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print Errors for config validation #94

Closed
Wambere opened this issue Dec 15, 2023 · 1 comment
Closed

Print Errors for config validation #94

Wambere opened this issue Dec 15, 2023 · 1 comment
Assignees
@lincmba

Comments

@Wambere
Copy link
Contributor

Wambere commented Dec 15, 2023 •
edited
Loading

Currently the config validation works like any regular JSON schema validation by throwing the error and exiting when it runs into an error. We need to modify this so that it is printing all the errors in the terminal like all the other efsity validating functions and only exiting on completion. This will make it easier to see all the errors and fix them once instead of having to run and fix the issues one at a time
lincmba added a commit that referenced this issue Dec 22, 2023
@lincmba
Print config errors instead of exiting
cfeabaf 
 fixes ##94
lincmba added a commit that referenced this issue Dec 22, 2023
@lincmba
Print config errors instead of exiting
bd3ede5 
 fixes ##94
@lincmba lincmba mentioned this issue Dec 22, 2023
Merged
2 tasks
pld added a commit that referenced this issue Jan 8, 2024
@lincmba @pld
Print config errors instead of exiting (#99)
92411e8 
fixes ##94

Co-authored-by: Peter Lubell-Doughtie <[email protected]>
pld added a commit that referenced this issue Jan 8, 2024
@lincmba @pld
Add config tests 1 (#100)
387ffbe 
* Print config errors instead of exiting
 fixes ##94

* Add config tests
 Succeeds #98
 Tests should run against the changes on this PR #99
 fixes #93

---------

Co-authored-by: Peter Lubell-Doughtie <[email protected]>
@ndegwamartin
Copy link
Contributor

Closing this since PR is merged in here #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lincmba lincmba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wambere @ndegwamartin @lincmba