Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onedpl][ranges][test] Added std ranges to oneDPL Tested API #1571
[onedpl][ranges][test] Added std ranges to oneDPL Tested API #1571
Changes from 17 commits
65cd631
fc5ca24
b85d785
5557d26
721482c
639d059
0a5c48b
4b565c8
c2d30fb
7a6d27a
ea39a93
92d62b0
f52cddd
ea7ccda
905ca41
97b6cc1
1b0955f
f74c6dd
eba77cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also check
prev()
,next()
andadvance()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to within a kernel any range/view must be a random access view, testing of
advance
doesn't have much sense, I guess...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must work, practically (I do not expect an implementer to rely on recursion here, for example). I would check it anyway as it is easy, however I would not insist if you do not do it.