Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate usage of wait-on-check for commenting result of e2e workflows #1740

Open
kbenzie opened this issue Jun 11, 2024 · 1 comment
Open
Labels
ci/cd Continuous integration/devliery

Comments

@kbenzie
Copy link
Contributor

kbenzie commented Jun 11, 2024

I found something like this: https://github.com/marketplace/actions/wait-on-check It polls PRs jobs for status. I wonder whether it would be possible to do that, and then extract E2E test status from the job logs.

you could wait up, read the log, but there would be still the same problem - reporting it back to PR requires write permission, which we don't have here... or am I missing something in this wait-on-check action?

Originally posted by @lukaszstolarczuk in #1734 (comment)

@lukaszstolarczuk lukaszstolarczuk changed the title Investigate usage of wiat-on-check for commenting result of e2e workflows Investigate usage of wait-on-check for commenting result of e2e workflows Jun 11, 2024
@lukaszstolarczuk lukaszstolarczuk added the ci/cd Continuous integration/devliery label Jun 11, 2024
@pbalcer
Copy link
Contributor

pbalcer commented Jun 11, 2024

you could wait up, read the log, but there would be still the same problem - reporting it back to PR requires write permission, which we don't have here... or am I missing something in this wait-on-check action?

This would be an entirely standalone job with on: [pull_request] trigger. We'd then use wait-on-check inside of it to wait for the E2E jobs to complete. Once they are, github-script should allow us to then download and parse the logs from that job. It's certainly convoluted, but should work in theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration/devliery
Projects
None yet
Development

No branches or pull requests

3 participants