Fabio/cmd buffer kernel update staging #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
fabiomestre
force-pushed
the
fabio/cmd_buffer_kernel_update_staging
branch
7 times, most recently
from
22753f2
to
9ff534c
Compare
fabiomestre
force-pushed
the
fabio/cmd_buffer_kernel_update_staging
branch
2 times, most recently
from
96bfa9c
to
dce24a9
Compare
- Updates the specification to add support for command-buffer kernel handle updates.
- Adds new UR tests for this feature.
- Adds an implementation for the Cuda and Hip adapters.
- Changes the UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP enum to a new UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_CAPABILITIES_EXP which uses a bitfield instead of a boolean.
- Changes the spec for urCommandBufferUpdateKernelLaunchExp and ur_exp_command_buffer_update_kernel_launch_desc_t to make it more intuitive with less complicated errors codes:
- Passing a non-nullptr local work-group will now always update the command to use that value.
- Passing a nullptr local work-group will now always keep the current command behaviour (either generated by the implementation or user-defined).
- Passing zero to newWorkDim is now an error.
fabiomestre
force-pushed
the
fabio/cmd_buffer_kernel_update_staging
branch
from
dce24a9
to
d944ff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.