From 789dd35ad937ad21e10e41cc3e00f2beb7bb676f Mon Sep 17 00:00:00 2001
From: liangbowen <liangbowen@gf.com.cn>
Date: Sun, 22 Oct 2023 22:52:02 +0800
Subject: [PATCH] [CELEBORN-1065] Prevent the local variable 'time' declared in
 one 'switch' branch and used in another

### What changes were proposed in this pull request?
- Minor code improvement in `MetaHandler`
  - Local variable 'time' declared in one 'switch' branch `AppHeartbeat` and used in another branch `WorkerHeartbeat`

### Why are the changes needed?

- Incorrect code pattern.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI tests.

Closes #2012 from bowenliang123/time.

Authored-by: liangbowen <liangbowen@gf.com.cn>
Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
---
 .../service/deploy/master/clustermeta/ha/MetaHandler.java      | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java b/master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java
index 2bbc8ab4427..533d10016b0 100644
--- a/master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java
+++ b/master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java
@@ -173,7 +173,6 @@ public ResourceResponse handleWriteRequest(ResourceProtos.ResourceRequest reques
               replicatePort,
               diskInfos,
               userResourceConsumption);
-          time = request.getWorkerHeartbeatRequest().getTime();
           metaSystem.updateWorkerHeartbeatMeta(
               host,
               rpcPort,
@@ -183,7 +182,7 @@ public ResourceResponse handleWriteRequest(ResourceProtos.ResourceRequest reques
               diskInfos,
               userResourceConsumption,
               estimatedAppDiskUsage,
-              time,
+              request.getWorkerHeartbeatRequest().getTime(),
               highWorkload);
           break;