Skip to content
This repository has been archived by the owner on Aug 8, 2019. It is now read-only.

Update to Webpack 4 #124

Open
cmalven opened this issue Mar 2, 2018 · 2 comments
Open

Update to Webpack 4 #124

cmalven opened this issue Mar 2, 2018 · 2 comments
Milestone

Comments

@cmalven
Copy link
Collaborator

cmalven commented Mar 2, 2018

This generator always installs the latest version of Webpack (which is now v4) and Webpack v4 removes support for the CommonsChunkPlugin, which should be replaced with config.optimization.splitChunks.

So if you create a new project with this generator right now, you'll get an error when bundling with Webpack.

Webpack 4.0 doesn't even have documentation available yet so might be easiest to wait until that happens before trying to do anything about this.

Temporary solution if you run into this is to update your web pack version in package.json to 3.11.0 and run yarn install again.

@cmalven
Copy link
Collaborator Author

cmalven commented Mar 17, 2018

Temporary fix implemented in #144

We should keep this issue open until we've successfully migrated to 4.0

@cmalven cmalven added the v2 label Mar 17, 2018
@brianjhanson brianjhanson added this to the V2 milestone Mar 22, 2018
@cmalven
Copy link
Collaborator Author

cmalven commented Mar 31, 2018

So far the best source of migration info I’ve found: https://developers.google.com/web/fundamentals/performance/webpack/decrease-frontend-size

brianjhanson added a commit that referenced this issue May 27, 2018
Updates Webpack to 4.0 and moves the linting task out of gulp
and into webpack.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants