Implement missing streaming methods #658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterargue can you have a look? I want to be 100% sure what I did is correct before requesting a review. |
peterargue
reviewed
May 10, 2024
| isNotFound := errors.As(err, &blockNotFoundByIDError) | ||
| if !isNotFound { | ||
| //check latest block request | ||
| if blockID != flow.ZeroID && height == 0 { |
There was a problem hiding this comment.
I recommend switching this to use the new start height approach. this older approach requires more complicated client and server side logic and makes it hard to stream from block 0
|
those are fixed on another PR closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #657
Description
Implements new streaming methods, not sure if it is need to back port this.
For contributor use:
masterbranchFiles changedin the GitHub PR explorer