Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor on EVM.COA.deploy return value #25

Closed
sisyphusSmiling opened this issue Apr 3, 2024 · 2 comments · Fixed by #42
Closed

Refactor on EVM.COA.deploy return value #25

sisyphusSmiling opened this issue Apr 3, 2024 · 2 comments · Fixed by #42
Assignees
@sisyphusSmiling
Labels
Chore Deployment Requires contract deployment or update

Comments

@sisyphusSmiling
Copy link
Contributor

Issue To Be Solved

As mentioned in this PR comment, deploy will soon return an EVM.Result struct.

Suggest A Solution

Instances of deploy calls will need to be refactored to handle the updated return type.
@sisyphusSmiling sisyphusSmiling mentioned this issue Apr 3, 2024
Merged
6 tasks
@sisyphusSmiling
Copy link
Contributor Author

Related: onflow/flow-go#5606

@sisyphusSmiling sisyphusSmiling mentioned this issue Apr 19, 2024
Merged
6 tasks
@sisyphusSmiling
Copy link
Contributor Author

Update: waiting on CLI pre-release to include the updated EVM interface which will enable CI tests to run in #42

@sisyphusSmiling sisyphusSmiling added Chore Deployment Requires contract deployment or update labels May 2, 2024
@sisyphusSmiling sisyphusSmiling self-assigned this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sisyphusSmiling sisyphusSmiling

Labels
Chore Deployment Requires contract deployment or update
Projects
FlowEVM Bridge
Status: Done
🌊 Flow 4D
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update against new EVM interface & NFT interfaces onflow/flow-evm-bridge
1 participant
@sisyphusSmiling