Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EVMAddress comparison implementation #97

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Update EVMAddress comparison implementation #97

merged 1 commit into from
Jul 3, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Jul 1, 2024 •
edited
Loading

Closes: #96

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Jul 1, 2024
@sisyphusSmiling sisyphusSmiling changed the title Update EVMAddress comparison method Update EVMAddress comparison implementation Jul 1, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review July 1, 2024 18:34
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner July 1, 2024 18:34
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.33%. Comparing base (02aab3f) to head (67e41df).
Report is 62 commits behind head on main.

Files Patch % Lines
cadence/contracts/bridge/FlowEVMBridgeUtils.cdc 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   86.19%   86.33%   +0.13%     
==========================================
  Files          18       17       -1     
  Lines         884      922      +38     
==========================================
+ Hits          762      796      +34     
- Misses        122      126       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling merged commit aed9fbb into main Jul 3, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the update-evm-address-comparator branch July 3, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuahannan joshuahannan joshuahannan approved these changes

Assignees

@sisyphusSmiling sisyphusSmiling

Labels
Improvement
Projects
FlowEVM Bridge
Status: Done
🌊 Flow 4D
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update EVM Address comparison
3 participants
@sisyphusSmiling @codecov-commenter @joshuahannan