Ledger: Move trie validation step to only export time (#172)

ledger/complete/ledger.go

@@ -254,25 +254,38 @@ func (l *Ledger) ExportCheckpointAt(state ledger.State,
 	targetPathFinderVersion uint8,
 	outputFilePath string) (ledger.State, error) {
 
+	l.logger.Info().Msgf("Ledger is loaded, checkpoint Export has started for state %s, and %d migrations has been planed", state.String(), len(migrations))
+
 	// get trie
 	t, err := l.forest.GetTrie(ledger.RootHash(state))
 	if err != nil {
 		return nil, fmt.Errorf("cannot get try at the given state commitment: %w", err)
 	}
 
+	// TODO enable validity check of trie
+	// only check validity of the trie we are interested in
+	// l.logger.Info().Msg("Checking validity of the trie at the given state...")
+	// if !t.IsAValidTrie() {
+	//	 return nil, fmt.Errorf("trie is not valid: %w", err)
+	// }
+	// l.logger.Info().Msg("Trie is valid.")
+
 	// get all payloads
 	payloads := t.AllPayloads()
 	payloadSize := len(payloads)
 
 	// migrate payloads
 	for i, migrate := range migrations {
+		l.logger.Info().Msgf("migration %d is underway", i)
+
 		payloads, err = migrate(payloads)
 		if err != nil {
 			return nil, fmt.Errorf("error applying migration (%d): %w", i, err)
 		}
 		if payloadSize != len(payloads) {
 			l.logger.Warn().Int("migration_step", i).Int("expected_size", payloadSize).Int("outcome_size", len(payloads)).Msg("payload counts has changed during migration, make sure this is expected.")
 		}
+		l.logger.Info().Msgf("migration %d is done", i)
 	}
 
 	// run reporters
@@ -283,6 +296,8 @@ func (l *Ledger) ExportCheckpointAt(state ledger.State,
 		}
 	}
 
+	l.logger.Info().Msgf("constructing a new trie with migrated payloads (count: %d)...", len(payloads))
+
 	// get paths
 	paths, err := pathfinder.PathsFromPayloads(payloads, targetPathFinderVersion)
 	if err != nil {
@@ -299,6 +314,8 @@ func (l *Ledger) ExportCheckpointAt(state ledger.State,
 		return nil, fmt.Errorf("constructing updated trie failed: %w", err)
 	}
 
+	l.logger.Info().Msg("creating a checkpoint for the new trie")
+
 	writer, err := wal.CreateCheckpointWriterForFile(outputFilePath)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create a checkpoint writer: %w", err)
@@ -309,6 +326,8 @@ func (l *Ledger) ExportCheckpointAt(state ledger.State,
 		return nil, fmt.Errorf("failed to flatten the trie: %w", err)
 	}
 
+	l.logger.Info().Msg("storing the checkpoint to the file")
+
 	err = wal.StoreCheckpoint(flatTrie.ToFlattenedForestWithASingleTrie(), writer)
 	if err != nil {
 		return nil, fmt.Errorf("failed to store the checkpoint: %w", err)

ledger/complete/mtrie/flattener/forest.go

@@ -126,9 +126,6 @@ func RebuildTries(flatForest *FlattenedForest) ([]*trie.MTrie, error) {
 		if err != nil {
 			return nil, fmt.Errorf("restoring trie failed: %w", err)
 		}
-		if !mtrie.IsAValidTrie() {
-			return nil, fmt.Errorf("restoring trie failed: the constructed trie is not a valid trie")
-		}
 		if !bytes.Equal(storableTrie.RootHash, mtrie.RootHash()) {
 			return nil, fmt.Errorf("restoring trie failed: roothash doesn't match")
 		}