You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current UnicastConfigEntity type has the implementation of Entity on it. Review the UnicastConfigEntity type to check that ID() method is being used and if so confirm that its ID() returns unique hash of all the content of UnicastConfigEntity according to encoding rlp rules.
Definition of done
Check usages of the ID() method.
All structure fields are verified to be included in the hash.
Make sure all tests work as expected.
The text was updated successfully, but these errors were encountered:
UlyanaAndrukhiv
changed the title
[Malleability A] UnicastConfigEntity
Malleability] Fix ID misuse in UnicastConfigEntity type
Feb 11, 2025
UlyanaAndrukhiv
changed the title
Malleability] Fix ID misuse in UnicastConfigEntity type
[Malleability] Fix ID misuse in UnicastConfigEntity type
Feb 11, 2025
Moved this issue to [EPIC] Refactor herocache/mempool package because UnicastConfigEntity is internally used by the cache and misused ID() to be compatible with herocache.
Context
The current
UnicastConfigEntity
type has the implementation ofEntity
on it. Review theUnicastConfigEntity
type to check thatID()
method is being used and if so confirm that itsID()
returns unique hash of all the content ofUnicastConfigEntity
according to encoding rlp rules.Definition of done
ID()
method.The text was updated successfully, but these errors were encountered: