Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Malleability] Fix ID misuse in UnicastConfigEntity type #6691

Open
Tracked by #6646
UlyanaAndrukhiv opened this issue Nov 14, 2024 · 1 comment
Open
Tracked by #6646

[Malleability] Fix ID misuse in UnicastConfigEntity type #6691

UlyanaAndrukhiv opened this issue Nov 14, 2024 · 1 comment

Comments

@UlyanaAndrukhiv
Copy link
Contributor

UlyanaAndrukhiv commented Nov 14, 2024

Context

The current UnicastConfigEntity type has the implementation of Entity on it. Review the UnicastConfigEntity type to check that ID() method is being used and if so confirm that its ID() returns unique hash of all the content of UnicastConfigEntity according to encoding rlp rules.

Definition of done

  1. Check usages of the ID() method.
  2. All structure fields are verified to be included in the hash.
  3. Make sure all tests work as expected.
@UlyanaAndrukhiv UlyanaAndrukhiv self-assigned this Feb 11, 2025
@UlyanaAndrukhiv UlyanaAndrukhiv changed the title [Malleability A] UnicastConfigEntity Malleability] Fix ID misuse in UnicastConfigEntity type Feb 11, 2025
@UlyanaAndrukhiv UlyanaAndrukhiv changed the title Malleability] Fix ID misuse in UnicastConfigEntity type [Malleability] Fix ID misuse in UnicastConfigEntity type Feb 11, 2025
@UlyanaAndrukhiv
Copy link
Contributor Author

UlyanaAndrukhiv commented Feb 11, 2025

Moved this issue to [EPIC] Refactor herocache/mempool package because UnicastConfigEntity is internally used by the cache and misused ID() to be compatible with herocache.

@UlyanaAndrukhiv UlyanaAndrukhiv removed their assignment Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant