Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EFM Recovery ] Backward-compatibility for EpochCommit service event conversion logic #6787

Closed
jordanschalm opened this issue Dec 6, 2024 · 1 comment
Labels
Protocol Team: Issues assigned to the Protocol Pillar. S-BFT

Comments

@jordanschalm
Copy link
Member

Context

We are deploying EFM Recovery as a Protocol HCU, so software changes need to be backward compatible with existing state and upgrade-safe. See Upgrade Plan (Notion) for details.

This issue is for implementing backward-compatibility for the EpochCommit service event parsing logic. The new EpochCommit service event has new fields, and changes the semantics of one existing field:

  • EpochCommit.dkgIdMapping field - new field added
  • EpochCommit.dkgGroupKey field - new field added
  • EpochCommit.dkgPubKeys field - existing field, semantics changed to omit group key

We can detect which service event type we are operating on by the existence of the new fields.

Definition of Done

  • Implement conditional service event parsing logic, with one path for the old event model, and one path for the new event model
  • Implement tests against both old and new service event model types
@jordanschalm jordanschalm added Protocol Team: Issues assigned to the Protocol Pillar. S-BFT labels Dec 6, 2024
@durkmurder
Copy link
Member

Implemented in #6795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Protocol Team: Issues assigned to the Protocol Pillar. S-BFT
Projects
None yet
Development

No branches or pull requests

3 participants